-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LogEventInfo.MessageFormatter - External Structured Logging Formatter #2244
LogEventInfo.MessageFormatter - External Structured Logging Formatter #2244
Conversation
39909f3
to
8368855
Compare
Can make extra PRs for CoreCLR and release-4.4.12. This will allow jump-start of structured-logging support for NLog.Extensions.Logging. Maybe combined with #2241 Will then update #2208 to work through the new official LogEventInfo.MessageFormatter, so structured logging support is also added for the internal NLog-MesageFormatter (instead of just string.Format) |
8368855
to
e4f7138
Compare
Codecov Report
@@ Coverage Diff @@
## master #2244 +/- ##
=======================================
+ Coverage 82% 82% +<1%
=======================================
Files 304 304
Lines 21126 21137 +11
Branches 2531 2533 +2
=======================================
+ Hits 17275 17287 +12
+ Misses 3216 3211 -5
- Partials 635 639 +4 |
e4f7138
to
73d8dc7
Compare
…structured logging
73d8dc7
to
4ff1b86
Compare
@304NotModified Removed some premature optimization regarding FormatProvider (Too many side-effects in attempt to save 8 byte) |
👍 |
Thanks! Merged! |
Updated some documentation: |
Thanks! |
Add support for external Message Formatter. This will allow integration with external logger formatters like Microsoft.Extensions.Logging. See also NLog/NLog.Extensions.Logging#125