LogEventInfo.MessageFormatter - External Structured Logging Formatter #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
LogEventInfoMessageFormatter
branch
2 times, most recently
from
39909f3
to
8368855
Compare
|
Can make extra PRs for CoreCLR and release-4.4.12. This will allow jump-start of structured-logging support for NLog.Extensions.Logging. Maybe combined with #2241 Will then update #2208 to work through the new official LogEventInfo.MessageFormatter, so structured logging support is also added for the internal NLog-MesageFormatter (instead of just string.Format) |
snakefoot
force-pushed
the
LogEventInfoMessageFormatter
branch
from
8368855
to
e4f7138
Compare
Codecov Report
@@ Coverage Diff @@
## master #2244 +/- ##
=======================================
+ Coverage 82% 82% +<1%
=======================================
Files 304 304
Lines 21126 21137 +11
Branches 2531 2533 +2
=======================================
+ Hits 17275 17287 +12
+ Misses 3216 3211 -5
- Partials 635 639 +4 |
snakefoot
force-pushed
the
LogEventInfoMessageFormatter
branch
from
e4f7138
to
73d8dc7
Compare
…structured logging
snakefoot
force-pushed
the
LogEventInfoMessageFormatter
branch
from
73d8dc7
to
4ff1b86
Compare
|
@304NotModified Removed some premature optimization regarding FormatProvider (Too many side-effects in attempt to save 8 byte) |
|
👍 |
|
Thanks! Merged! |
Closed
|
Updated some documentation: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for external Message Formatter. This will allow integration with external logger formatters like Microsoft.Extensions.Logging. See also NLog/NLog.Extensions.Logging#125