-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WhenRepeatedFilter - Log after timeout #2297
WhenRepeatedFilter - Log after timeout #2297
Conversation
bdf7eba
to
6f90762
Compare
Codecov Report
@@ Coverage Diff @@
## master #2297 +/- ##
=======================================
+ Coverage 82% 82% +<1%
=======================================
Files 304 304
Lines 21414 21429 +15
Branches 2579 2581 +2
=======================================
+ Hits 17517 17547 +30
+ Misses 3229 3227 -2
+ Partials 668 655 -13 |
How does this resolve #2295? |
|
Could also consider not abusing the Action-property. But just introduce a new property called IncludeFirst=true/false (default=false), where it also applies the action to the initial event starting the timeout-period. |
6f90762
to
f44ad65
Compare
…r the initial LogEvent.
f44ad65
to
3e88407
Compare
Hi @snakefoot, this is exactly the functionality I was looking for! |
OK great! great work @snakefoot ! |
Updated documentation: |
Attempt to resolve #2295
Added new property IncludeFirst=true/false (default=false), that controls whether it applies the configured action to the initial logevent.
When IncludeFirst=true then the initial logevent will start a timeout-period (but without it being logged), so only when the timeout-period expires then the first logevent is logged.