NLog - NETSTANDARD1_5 (Fix uppercase with culture) #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, but I seldom see configurations that are not invariant. So it would probably have taken a while for it to be discovered. Anyways like to look at the code, some time after it has been written, then my brain don't auto-fix the code so it seems correct (especially when in the non-unit-test arena) |
Codecov Report
@@ Coverage Diff @@
## master #2349 +/- ##
======================================
Coverage 82% 82%
======================================
Files 318 318
Lines 22771 22771
Branches 2782 2782
======================================
Hits 18659 18659
Misses 3410 3410
Partials 702 702 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.