Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLog - MessageTemplates - Renamed config to parseMessageTemplates #2356

Merged
merged 1 commit into from
Oct 14, 2017
Merged

NLog - MessageTemplates - Renamed config to parseMessageTemplates #2356

merged 1 commit into from
Oct 14, 2017

Conversation

snakefoot
Copy link
Contributor

Trying to resolve #2347

@304NotModified
Copy link
Member

304NotModified commented Oct 14, 2017 •
edited

Please update Also the xsd, thx! See https://github.com/NLog/NLog/pull/2346/files

@snakefoot
Copy link
Contributor Author

Please update Also the xsd

Done

@304NotModified
Copy link
Member

Thx, its easy to forget.

@304NotModified 304NotModified added the enhancement Improvement on existing feature label Oct 14, 2017
@304NotModified 304NotModified added this to the 4.5 beta 7 milestone Oct 14, 2017
@codecov
Copy link

codecov bot commented Oct 14, 2017

Codecov Report

Merging #2356 into master will decrease coverage by <1%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #2356    +/-   ##
=======================================
- Coverage      82%     82%   -<1%     
=======================================
  Files         318     318            
  Lines       22771   22771            
  Branches     2782    2782            
=======================================
- Hits        18665   18663     -2     
- Misses       3403    3405     +2     
  Partials      703     703

@304NotModified 304NotModified merged commit bda23b0 into NLog:master Oct 14, 2017
@snakefoot snakefoot deleted the ParseMessageTemplates branch December 4, 2017 19:50
@snakefoot snakefoot modified the milestones: 4.5 beta 7, 4.5 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

Assignees
No one assigned
Labels
enhancement Improvement on existing feature XSD change
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snakefoot @304NotModified