LogEventInfo.StackTrace moved into CallSiteInformation #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
LogEventCallSite
branch
3 times, most recently
from
6046bd0
to
0852ecc
Compare
Codecov Report
@@ Coverage Diff @@
## master #2386 +/- ##
=======================================
- Coverage 82% 82% -<1%
=======================================
Files 318 319 +1
Lines 22796 22898 +102
Branches 2789 2824 +35
=======================================
+ Hits 18671 18705 +34
- Misses 3419 3465 +46
- Partials 706 728 +22 |
snakefoot
force-pushed
the
LogEventCallSite
branch
from
0852ecc
to
1820287
Compare
snakefoot
force-pushed
the
LogEventCallSite
branch
from
1820287
to
34dd342
Compare
| /// </summary> | ||
| private static HashSet<string> CallerInformationAttributeNames = new HashSet<string> | ||
| private static List<string> CallerInformationAttributeNames = new List<string> |
There was a problem hiding this comment.
why no hashset? Afaik it's more efficient with 3+ elements, and it's static
There was a problem hiding this comment.
Well I don't need the HashSet-lookup, and the struct-enumerator on List is allocation-free.
| return frame?.GetMethod(); | ||
| } | ||
|
|
||
| public string GetCallerClassName(MethodBase method, bool includeNameSpace, bool cleanAsyncMoveNext, bool cleanAnonymousDelegates) |
There was a problem hiding this comment.
What do you think about a struct/class for the last 3 parameters?
(the same object for GetCallerMemberName
Only for readability of the calling site.
There was a problem hiding this comment.
Have no opinion. But not that big fan of struct-parameters.
There was a problem hiding this comment.
OK,it's internal.so could be done in the future
This was referenced Nov 23, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to resolve #2382