NLogTraceListener - set DisableFlush true by default #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
NLogTraceListenerNoFlush
branch
from
e9f176d
to
05d1d10
Compare
|
Inspired by #2404 :) |
304NotModified
added
enhancement
304NotModified
changed the title
|
👍 good defaults are important |
304NotModified
approved these changes
Nov 18, 2017
Codecov Report
@@ Coverage Diff @@
## master #2407 +/- ##
========================================
Coverage ? 82%
========================================
Files ? 320
Lines ? 23016
Branches ? 2845
========================================
Hits ? 18772
Misses ? 3495
Partials ? 749 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NLog will automatically flush on AppDomain-shutdown, so going crazy and eating all threads when autoflush=true is not a good idea. See also #353
This gives a better out-of-box-experience, but also a breaking change, so should be deferred to NLog 4.5 or 5.0
Replaces #2142