-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for UWP platform #2441
Support for UWP platform #2441
Conversation
899f5a7
to
2b9ae83
Compare
@304NotModified This will move the last pieces from coreclr-branch into the master-branch. |
d7ee0e8
to
01c8650
Compare
Codecov Report
@@ Coverage Diff @@
## master #2441 +/- ##
=======================================
+ Coverage 81% 81% +<1%
=======================================
Files 322 322
Lines 23120 23135 +15
Branches 2868 2873 +5
=======================================
+ Hits 18829 18843 +14
+ Misses 3548 3546 -2
- Partials 743 746 +3 |
85b6347
to
17c4ac5
Compare
\o/ great work!! It was also working on this, but can't build "uap" or "uap10.0" on my local machine. (target not found). Reinstalled windows 10 SDK, but without luck. |
17c4ac5
to
cd409cc
Compare
Apparently it is very difficult to build anything, that is not net45 or netstandard. After more considerations then I have decided to not implement NetStandard1.3, but to make a dedicated uap10.0. It will cause too much confusion with a public available NetStandard1.3, that is missing lots of features. But I'm (ab)using the NetStandard1.3 TargetPlatform to simulate uap10.0 for those NLog-developers who doesn't have UWP installed. With the updated csproj in this PR, then you can build it locally with this command:
|
75b0d32
to
288c521
Compare
b06efec
to
c5e71f7
Compare
c5e71f7
to
fbb6be1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\0/
fixes #2440 |
works :) |
Yes because UWP apps can handle both uap10.0 and a restricted NetStandard1.3. So UWP should be able to load both, haven't tested if they work together. Guess a new issue can be created about unit testing UWP :)
…Sent from my Samsung device
-------- Original message --------
From: Julian Verdurmen <notifications@github.com>
Date: 03/12/2017 01:05 (GMT+01:00)
To: NLog/NLog <NLog@noreply.github.com>
Cc: Rolf Kristensen <sweaty1@hotmail.com>, Author <author@noreply.github.com>
Subject: Re: [NLog/NLog] Support for UWP platform (#2441)
is it correct that NLog.WCF supports .NET standard 1.3 and NLog support UWP (and not .NET Standard 1.3)?
[image]<https://user-images.githubusercontent.com/5808377/33521000-06a6da64-d7c6-11e7-86a4-ca8a4b77f6b8.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#2441 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AK-fnNXLU1yutcKNVyR0iy9yZdJvkAlRks5s8eXIgaJpZM4QzXDf>.
|
@gtbuchanan Would you mind trying out the new NLog 4.5 RC2, and see if the UWP-platform is working for you: |
@andyphilpotts Would you mind trying out the new NLog 4.5 RC2, and see if the UWP-platform is working for you: |
@owlstack Would you mind trying out the new NLog 4.5 RC2, and see if the UWP-platform is working for you: |
@shimonAzulay Would you mind trying out the new NLog 4.5 RC2, and see if the UWP-platform is working for you: |
@yschkatula Would you mind trying out the new NLog 4.5 RC2, and see if the UWP-platform is working for you: |
I'm sorry for the slow response, I had to flatten my machine and in so
doing abandoned UWP as a target, I have my project, but no tooling to
compile it (and no space to easily install said tooling!)
…On Mon, Dec 4, 2017, 3:50 PM Rolf Kristensen ***@***.***> wrote:
@andyphilpotts <https://github.com/andyphilpotts> Would you mind trying
out the new NLog 4.5 RC2, and see if the UWP-platform is working for you:
https://www.nuget.org/packages/NLog/4.5.0-rc02
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2441 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AG7-xRWTU6vtxoD2nnVNv2DOxZXWXX-Yks5s9FsYgaJpZM4QzXDf>
.
|
UWP [Win 10 Fall Creators Update (Build 16299)] supports System.Diagnostics.Trace. Is it planned to support <target xsi:type="Trace"../> for UWP? |
@hr-strunt Please create new issues for questions, instead of waking old giants. But new versions of UWP will support NetStandard2.0, that supports most target-types (https://blogs.msdn.microsoft.com/dotnet/2017/10/10/announcing-uwp-support-for-net-standard-2-0/) |
Support for UWP platform without System.Threading.Thread
UWP is not supporting Thread, ThreadPool, Named-Mutex, FileWatcher, Console or System.Diagnostics.Trace