Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for UWP platform #2441

Merged
merged 1 commit into from
Dec 3, 2017
Merged

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Dec 2, 2017

Support for UWP platform without System.Threading.Thread

UWP is not supporting Thread, ThreadPool, Named-Mutex, FileWatcher, Console or System.Diagnostics.Trace

@snakefoot snakefoot force-pushed the UwpNetStandard13 branch 3 times, most recently from 899f5a7 to 2b9ae83 Compare December 2, 2017 16:21
@snakefoot
Copy link
Contributor Author

@304NotModified This will move the last pieces from coreclr-branch into the master-branch.

@snakefoot snakefoot force-pushed the UwpNetStandard13 branch 4 times, most recently from d7ee0e8 to 01c8650 Compare December 2, 2017 16:47
@codecov
Copy link

codecov bot commented Dec 2, 2017

Codecov Report

Merging #2441 into master will increase coverage by <1%.
The diff coverage is 78%.

@@           Coverage Diff           @@
##           master   #2441    +/-   ##
=======================================
+ Coverage      81%     81%   +<1%     
=======================================
  Files         322     322            
  Lines       23120   23135    +15     
  Branches     2868    2873     +5     
=======================================
+ Hits        18829   18843    +14     
+ Misses       3548    3546     -2     
- Partials      743     746     +3

@snakefoot snakefoot force-pushed the UwpNetStandard13 branch 3 times, most recently from 85b6347 to 17c4ac5 Compare December 2, 2017 18:28
@304NotModified
Copy link
Member

\o/ great work!!

It was also working on this, but can't build "uap" or "uap10.0" on my local machine. (target not found). Reinstalled windows 10 SDK, but without luck.

@snakefoot
Copy link
Contributor Author

snakefoot commented Dec 2, 2017

It was also working on this, but can't build "uap" or "uap10.0" on my local machine.

Apparently it is very difficult to build anything, that is not net45 or netstandard.

After more considerations then I have decided to not implement NetStandard1.3, but to make a dedicated uap10.0. It will cause too much confusion with a public available NetStandard1.3, that is missing lots of features.

But I'm (ab)using the NetStandard1.3 TargetPlatform to simulate uap10.0 for those NLog-developers who doesn't have UWP installed.

With the updated csproj in this PR, then you can build it locally with this command:

msbuild /t:restore,build src\NLog /p:targetFrameworks="uap10.0"

@snakefoot snakefoot force-pushed the UwpNetStandard13 branch 4 times, most recently from 75b0d32 to 288c521 Compare December 2, 2017 20:12
@snakefoot snakefoot changed the title NetStandard1.3 without System.Threading.Thread for UWP UWP without System.Threading.Thread Dec 2, 2017
@snakefoot snakefoot force-pushed the UwpNetStandard13 branch 3 times, most recently from b06efec to c5e71f7 Compare December 2, 2017 21:32
Copy link
Member

@304NotModified 304NotModified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\0/

@304NotModified 304NotModified changed the title UWP without System.Threading.Thread Support for UWP platform Dec 2, 2017
@304NotModified 304NotModified added this to the 4.5 rc2 milestone Dec 2, 2017
@304NotModified
Copy link
Member

fixes #2440

@304NotModified
Copy link
Member

is it correct that NLog.WCF supports .NET standard 1.3 and NLog support UWP (and not .NET Standard 1.3)?

image

@304NotModified
Copy link
Member

msbuild /t:restore,build src\NLog /p:targetFrameworks="uap10.0"

works :)

@304NotModified 304NotModified merged commit fd6e91a into NLog:master Dec 3, 2017
@snakefoot
Copy link
Contributor Author

snakefoot commented Dec 3, 2017 via email

@snakefoot snakefoot mentioned this pull request Dec 3, 2017
@snakefoot snakefoot deleted the UwpNetStandard13 branch December 4, 2017 19:47
@snakefoot
Copy link
Contributor Author

@gtbuchanan Would you mind trying out the new NLog 4.5 RC2, and see if the UWP-platform is working for you:

https://www.nuget.org/packages/NLog/4.5.0-rc02

@snakefoot
Copy link
Contributor Author

@andyphilpotts Would you mind trying out the new NLog 4.5 RC2, and see if the UWP-platform is working for you:

https://www.nuget.org/packages/NLog/4.5.0-rc02

@snakefoot
Copy link
Contributor Author

@owlstack Would you mind trying out the new NLog 4.5 RC2, and see if the UWP-platform is working for you:

https://www.nuget.org/packages/NLog/4.5.0-rc02

@snakefoot
Copy link
Contributor Author

@shimonAzulay Would you mind trying out the new NLog 4.5 RC2, and see if the UWP-platform is working for you:

https://www.nuget.org/packages/NLog/4.5.0-rc02

@snakefoot
Copy link
Contributor Author

@yschkatula Would you mind trying out the new NLog 4.5 RC2, and see if the UWP-platform is working for you:

https://www.nuget.org/packages/NLog/4.5.0-rc02

@sirxyzzy
Copy link

sirxyzzy commented Dec 30, 2017 via email

@hr-strunt
Copy link

UWP [Win 10 Fall Creators Update (Build 16299)] supports System.Diagnostics.Trace. Is it planned to support <target xsi:type="Trace"../> for UWP?

@snakefoot
Copy link
Contributor Author

@hr-strunt Please create new issues for questions, instead of waking old giants. But new versions of UWP will support NetStandard2.0, that supports most target-types (https://blogs.msdn.microsoft.com/dotnet/2017/10/10/announcing-uwp-support-for-net-standard-2-0/)

@snakefoot snakefoot modified the milestones: 4.5 rc2, 4.5 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants