Added ${currentDir}

[UgurAldanmaz]

I've implemetend the CurrentDirLayoutRenderer which was requested in #2190.

I cannot remember what we do for adding new files to the .csproj file. Cannot find any info at the contributing document. Please guide me if I've missed anything.

[codecov]

Codecov Report

Merging #2491 into master will decrease coverage by <1%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #2491    +/-   ##
=======================================
- Coverage      82%     82%   -<1%     
=======================================
  Files         322     323     +1     
  Lines       23422   23211   -211     
  Branches     2974    2883    -91     
=======================================
- Hits        19144   18936   -208     
- Misses       3511    3524    +13     
+ Partials      767     751    -16

[304NotModified]

I cannot remember what we do for adding new files to the .csproj file. Cannot find any info at the contributing document. Please guide me if I've missed anything.

Since VS2017, there is no need to list all the files in the csproj :)
Also there is now 1 sln/csproj for all platforms. So nothing to do here :)

Thx for contributing. I'm a bit busy these weeks, will try to review it soon!

[snakefoot]

@UgurAldanmaz Maybe it should be called "startupdir" instead of "currentdir" ? (Since the layout renderer caches the currentdir as startupdir).

[304NotModified]

Where is the cache?

[snakefoot]

It is a member variable

…

Sent from my Samsung device

-------- Original message -------- From: Julian Verdurmen <notifications@github.com> Date: 08/01/2018 21:07 (GMT+01:00) To: NLog/NLog <NLog@noreply.github.com> Cc: Rolf Kristensen <sweaty1@hotmail.com>, Comment <comment@noreply.github.com> Subject: Re: [NLog/NLog] Implemented CurrentDirLayoutRenderer (#2491) Where is the cache? — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#2491 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AK-fnFescV6Of_DsYCxrt8o5mYRsl1Y7ks5tInV_gaJpZM4RV1-Q>.

[UgurAldanmaz]

Since VS2017, there is no need to list all the files in the csproj :)
Also there is now 1 sln/csproj for all platforms. So nothing to do here :)

Nice 👍

Thx for contributing. I'm a bit busy these weeks, will try to review it soon!

I'm very happy to come back to the community.

@UgurAldanmaz Maybe it should be called "startupdir" instead of "currentdir" ? (Since the layout renderer caches the currentdir as startupdir).

Yes, currentdir looks confusing. My suggestion is appdir as its documentation says

Gets the current working directory of the application.

Thoughts?

[304NotModified]

It is a member variable

ow yes indeed. I think that's not needed. If someone likes to cache it, it should use ${currentDir:cache=true}

@UgurAldanmaz could you please remove the "cache"?

[UgurAldanmaz]

I've removed, tx!

[304NotModified]

thx! Looks good! Some unit tests are a bit unstable, will restart Travis

[304NotModified]

merged! Thanks!

[304NotModified]

Could you please create a wiki page? Thanks!

[UgurAldanmaz]

Could you please create a wiki page? Thanks!

Of course, it is here. I will link it to the main layout renderer list page, when we release it.

[304NotModified]

thx @UgurAldanmaz !!