Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added TooManyStructuredParametersShouldKeepBeInParamList testcase #2542

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Added TooManyStructuredParametersShouldKeepBeInParamList testcase #2542

merged 1 commit into from
Feb 12, 2018

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Jan 23, 2018 •
edited

todo

  • rebase

@304NotModified 304NotModified added this to the 4.5 milestone Jan 23, 2018
@304NotModified 304NotModified force-pushed the TooManyStructuredParametersShouldKeepBeInParamList branch from 0139f5d to 015dd31 Compare February 6, 2018 19:56
@snakefoot
Copy link
Contributor

@304NotModified What is the purpose of this PR ?

@304NotModified
Copy link
Member Author

304NotModified commented Feb 12, 2018 •
edited

I added a test, but I made a mistake with rebasing

update: rebase was OK, needed to change the PR's base

@304NotModified 304NotModified changed the base branch from structured-test-cases to master February 12, 2018 09:44
@304NotModified 304NotModified force-pushed the TooManyStructuredParametersShouldKeepBeInParamList branch from 015dd31 to 9b8d56c Compare February 12, 2018 09:48
@codecov
Copy link

codecov bot commented Feb 12, 2018 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@29704d6). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #2542   +/-   ##
========================================
  Coverage          ?     82%           
========================================
  Files             ?     323           
  Lines             ?   24075           
  Branches          ?    3098           
========================================
  Hits              ?   19706           
  Misses            ?    3574           
  Partials          ?     795

@304NotModified 304NotModified changed the title Added TooManyStructuredParametersShouldKeepBeInParamList testcase [WIP] Added TooManyStructuredParametersShouldKeepBeInParamList testcase Feb 12, 2018
@304NotModified 304NotModified merged commit dafbc69 into master Feb 12, 2018
@304NotModified 304NotModified deleted the TooManyStructuredParametersShouldKeepBeInParamList branch February 12, 2018 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
unit-tests
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@304NotModified @snakefoot