MessageTemplateParameter(s) ctors to internal

[304NotModified]

fixes #2552

• small c#7 change

[304NotModified]

@snakefoot decline this and wontfix for #2552?

[snakefoot]

I was thinking to allow use of MessageTemplateParameters constructor to access the internal parser. The MessageTemplateParameter struct is used by NLog.Extensions to capture Microsoft Extension Logging Message Properties. But we don't need two constructors, only the one with CaptureType

…

Sent from my Samsung device

-------- Original message -------- From: Julian Verdurmen <notifications@github.com> Date: 19/02/2018 21:19 (GMT+00:00) To: NLog/NLog <NLog@noreply.github.com> Cc: Rolf Kristensen <sweaty1@hotmail.com>, Mention <mention@noreply.github.com> Subject: Re: [NLog/NLog] MessageTemplateParameter(s) ctors to internal (#2581) @snakefoot<https://github.com/snakefoot> decline this and wontfix for #2552<#2552>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#2581 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AK-fnPuD2DYkB2IjFhfti5Q8UBfxywxPks5tWeVGgaJpZM4SLDZ8>.

[304NotModified]

So for both classes we need public ctors?

[codecov]

Codecov Report

Merging #2581 into master will decrease coverage by <1%.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master   #2581    +/-   ##
=======================================
- Coverage      81%     81%   -<1%     
=======================================
  Files         325     325            
  Lines       23918   23923     +5     
  Branches     3022    3023     +1     
=======================================
- Hits        19403   19393    -10     
+ Misses       3702    3698     -4     
- Partials      813     832    +19

[304NotModified]

I was thinking to allow use of MessageTemplateParameters constructor to access the internal parser.

No really a fan of this magic.

updated it: MessageTemplateParameter full ctor is still public

MessageTemplateParameters is internal ctor. IMO the ctor of MessageTemplateParameters do maybe to much parsing and so it's a good candidate to keep it internal.

Let me know if you agree

We can always open the ctor if we need it in the future.

[304NotModified]

PS I will try to create rc6 tonight/tomorrow. I hope that the latest RC before the RTM

@snakefoot if your still on holiday, have a good holiday :)

[snakefoot]

So for both classes we need public ctors?

Yes. I think so

[snakefoot]

MessageTemplateParameters is internal ctor. IMO the ctor of MessageTemplateParameters do maybe to much parsing and so it's a good candidate to keep it internal.

Will also work for me