Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement for [LogLevel]Exception methods #344

Merged
3 commits merged into from
May 22, 2014
Merged

Replacement for [LogLevel]Exception methods #344

3 commits merged into from
May 22, 2014

Conversation

ie-zero
Copy link
Contributor

@ie-zero ie-zero commented May 18, 2014

In Logger class

  • New public method added Log(LogLevel, String, Exception)
  • Method overloads added to replace eventually any [LogLevel]Exception(String, Exception) named methods

In Logger class
* New public method added Log(LogLevel, String, Exception)
* Method overloads added to replace eventually any
[Level]Exception(String, Exception) named methods
@ie-zero
Copy link
Contributor Author

ie-zero commented May 18, 2014

This pull request was created in relation to open issue #54 "Method overloads".

@ie-zero ie-zero mentioned this pull request May 18, 2014
Iraklis added 2 commits May 19, 2014 21:35
Default value can now specified on EnviromentLayoutRenderer along
variable name. When the variable has not defined the layout will return
the default value instead.
This reverts commit 0f46d43425a4ed967a627c839b784bc4f9bd8d65.
@ie-zero
Copy link
Contributor Author

ie-zero commented May 21, 2014

I committed by mistake two pieces of code implementing different features. Please disregard commits e9fd85f and 6a6651b

The only valid commit under "Replacement for [LogLevel]Exception methods" heading is the original one (4a583e9)

@ghost ghost added the enhancement label May 22, 2014
@ghost ghost added this to the 3.0 milestone May 22, 2014
ghost pushed a commit that referenced this pull request May 22, 2014
Replacement for [LogLevel]Exception methods
@ghost ghost merged commit ba5599a into NLog:master May 22, 2014
cvanbergen pushed a commit to cvanbergen/NLog that referenced this pull request Jul 2, 2014
In pull request NLog#344 "Replacement for [LogLevel]Exception methods" the
Obsolete attribute was missed for the LogException(LogLevel, String,
Exception) method in Logger class.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant