Issue #373 fixed #377
Merged
Issue #373 fixed #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added one more overload for the internal method that calls the faster overload of LogEventInfo.Create.
|
I thought about unit tests, but I don't understand how to check that the correct overload is called given that there are no interfaces to mock inside the library. Any suggestions are welcome. |
|
Thanks for the pull request, looks good. About the unit tests, it is not easily done before the logger has an interface, so no problem about that |
ghost
merged commit 
ghost
added
the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added one more overload for the internal method that calls the faster
overload of LogEventInfo.Create.
This resolves the performance issue #373