LogFactory Class Refactored #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New inner class LoggerCache added which encapsulates the operations related to Dictionary loggerCache. * The LoggerCacheKey class now implements the IEquatable. This can potentially improve performance in certain cases. * ReconfigExistingLoggers(LoggingConfiguration) internal method was merged into ReconfigExistingLoggers() public method as it was always invoked with the same parameter value of this.config * Renamed DisableLogging() and EnableLogging() methods in LogManager class to SuspendLogging() and ResumeLogging() respectively. This will align the naming with Microsoft conventions (see Control.ResumeLayout method). The DisableLogging() and EnableLogging() were marked as obsolete. * Remove CLSCompliant(false) attribute from various methods as it is not required. * Comments and code reformatted. * [Fix] Narrowed the captured exceptions within InvalidLoggerConfiguration tests in UnitTests\GetLoggerTests class. [Note] The name changes on DisableLogging() and EnableLogging() methods affect the public interface.
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to Dictionary loggerCache.
potentially improve performance in certain cases.
merged into ReconfigExistingLoggers() public method as it was always
invoked with the same parameter value of this.config
class to SuspendLogging() and ResumeLogging() respectively. This will
align the naming with Microsoft conventions (see Control.ResumeLayout
method). The DisableLogging() and EnableLogging() were marked as
obsolete.
required.
InvalidLoggerConfiguration tests in UnitTests\GetLoggerTests class.
[Note] The name changes on DisableLogging() and EnableLogging() methods
affect the public interface.