Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluent API available for ILogger interface #519

Merged
1 commit merged into from
Jan 27, 2015
Merged

Fluent API available for ILogger interface #519

1 commit merged into from
Jan 27, 2015

Conversation

ilya-g
Copy link
Contributor

@ilya-g ilya-g commented Jan 23, 2015

Now fluent API extension methods can be applied to the ILogger interface.

I have to attribute every method receiving ILogger paramater with CLSCompliant(false), because the ILogger itself is marked as non-CLSCompliant.

@304NotModified 304NotModified added this to the 4.0 milestone Jan 23, 2015
@304NotModified
Copy link
Member

Thanks for explaining the CLSCompliant(false) 👍

@ghost ghost self-assigned this Jan 27, 2015
ghost pushed a commit that referenced this pull request Jan 27, 2015
@kichristensen
Merge pull request #519 from ilya-g/FluentForILogger
fcf0daf 
Fluent API available for ILogger interface
@ghost ghost merged commit fcf0daf into NLog:master Jan 27, 2015
@ilya-g ilya-g deleted the FluentForILogger branch February 14, 2015 00:55
@ilya-g ilya-g restored the FluentForILogger branch February 14, 2015 00:55
@ilya-g ilya-g deleted the FluentForILogger branch February 14, 2015 00:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ilya-g @304NotModified