Fix for issue #507: NLog optional or empty mail recipient #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore empty recipient values by specifing the StringSplitOptions.RemoveEmptyEntries option. Write to internal logger if email sending failed. Add RequiredParameterAttribute to the SmtpServer property - it should be required according to the documentation - https://github.com/NLog/NLog/wiki/Mail-target#user-content-smtp-options. Throw NLogRuntimeException if one of the required parameters (From. To, SmtpServer) becomes empty after rendering. Add relevant unit tests to verify the expected behaviour.
YuLad
changed the title
|
Looks very good and thorough. I'll merge soon |
|
Meaning as soon as I figured why appveyor doesn't report failing tests to Github |
ghost
self-assigned this
ghost
pushed a commit
that referenced
this pull request
Jan 27, 2015
Fix for issue #507: NLog optional or empty mail recipient
ghost
merged commit
This was referenced Jun 13, 2015
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes summary:
StringSplitOptions.RemoveEmptyEntriesoption.MailTargetin the first commit.Fixes #507
This change is