-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Encoding property for consoleTarget + ColorConsoleTarget #692
Conversation
Looks good, but I think the using should be moved inside the |
I will update my PR. |
@Xharze I don't understand your comment I think:
|
@@ -31,6 +31,8 @@ | |||
// THE POSSIBILITY OF SUCH DAMAGE. | |||
// | |||
|
|||
using System.Text; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move inside #if !SILVERLIGHT
I've tried to add as a line comment :) |
Thanks, I fixed it :) Including also some doc/newlines stuff |
added Encoding property for consoleTarget + ColorConsoleTarget
Closes #676
No unit tests added as it is a small addition.
The property has a side effect (static property on
Console
), but I think we can live with that.