added Encoding property for consoleTarget + ColorConsoleTarget #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but I think the using should be moved inside the |
|
I will update my PR. |
|
@Xharze I don't understand your comment I think:
|
| @@ -31,6 +31,8 @@ | |||
| // THE POSSIBILITY OF SUCH DAMAGE. | |||
| // | |||
|
|
|||
| using System.Text; | |||
|
I've tried to add as a line comment :) |
|
Thanks, I fixed it :) Including also some doc/newlines stuff |
ghost
pushed a commit
that referenced
this pull request
May 11, 2015
added Encoding property for consoleTarget + ColorConsoleTarget
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #676
No unit tests added as it is a small addition.
The property has a side effect (static property on
Console), but I think we can live with that.