Fix for codeplex issue 6575

[ParthDesai]

This fix inject the pattern in the archive file name pattern so that even if user do not provide pattern in file name , code will inject it.

How the archiving is done is depend on three variables :
ArchiveEvery : Specifies Time period
ArchiveAboveSize : Specifies size
MaxArchiveFiles : Specifies maximum archived files to keep.

There are three cases mainly :

(1) Lets say developer has set ArchiveEvery to hour and ArchiveAboveSize to 10 MB
So , Whatever condition occurs first , then NLog will start archiving the current log file , in this case numbering is required otherwise NLog will overwrite the previous archive file.

(2) Lets say developer has set ArchiveEvery to none (default) and ArchiveAboveSize to 10 MB
So , in this case if the current log file's size is going to increase above 10 MB , then it will move this file to archive and create a new log file , in this case also we require numbering. Otherwise NLog will overwrite the previous file that was created when the size first increased.

(3) Lets say developer has set ArchiveEvery to hour and ArchiveAboveSize to -1(default)
So , in this case if the hour passed then regardless of the size of the log file , it will be moved to the archive . So , numbering is required. So After second hour if NLog archive the file then it should not overwrite the file that was created after completion of first hour.So , Numbering is required.

In all cases Numbering is required , because NLog will archive file upto MaxArchiveFiles specified.and We don't want to overwrite them.

[ghost]

The cases you mention requires numbering, but the case the bug report referes to doesn't. I'm not saying that you fix is incorrect, I'm just not sure this is the solution we want.
Another solution could be to require the numbering part in the filename.

[ParthDesai]

ok, I will reconsider my fix. And will try to improve.