Boolean value in array [is it possible?]

[kenkit]

Hi,
How would we create an array with random params like this
params can be order differently depending on the user needs.

{"jsonrpc": "1.0", "id":"curltest", "method": "importaddress", "params": ["myaddress", "testing", false] }

[kenkit]

This is how I was doing it but the last bool vector cannot work

  std::tuple<std::vector<std::string>, std::vector<int>, std::vector<bool>> params;
  request["params"] = nlohmann::json::array();
  for (auto param : std::get<0>(parameters))
  {
    request["params"].push_back(param);
  }
  for (auto param : std::get<1>(parameters))
  {
    request["params"].push_back(param);
  }
  for (auto param : std::get<2>(parameters))
  {
    request["params"].push_back(param);///fails here
  }

[falbrechtskirchinger]

std::vector<bool>::reference is not a bool & as on might expect (see https://en.cppreference.com/w/cpp/container/vector_bool).

Either of the options below should work.

  for (bool param : std::get<2>(parameters))
  {
    request["params"].push_back(param);
  }

  for (auto param : std::get<2>(parameters))
  {
    request["params"].push_back(static_cast<bool>(param));
  }

[nlohmann]

Would it make sense to teach the library how to automatically consume std::vector<bool>::reference?

[falbrechtskirchinger]

I looked into that earlier and didn't think it would be worth the effort.

[falbrechtskirchinger]

Ok, because you asked, I took a second look. It's not as bad as I thought. PR coming your way.

[nlohmann]

FYI: #3534 is merged.

[kenkit]

Nice, thank you.