Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake 3.1 in develop, when is it likely to make it into a stable release? #1498

Closed
phunkyfish opened this issue Feb 28, 2019 · 8 comments
Closed
Milestone

Comments

@phunkyfish
Copy link

There are certain build systems that don't support cmake 3.8, patching is one option while waiting for the next release but if it's imminent happy to wait.

@phunkyfish
Copy link
Author

Any chance of a 3.5.1 release that relaxes the cmake dependency?

@pboettch
Copy link
Contributor

pboettch commented Mar 6, 2019

See here: #1441

@phunkyfish
Copy link
Author

Ah, still in progress. Sorry, got lost in the threads. Thanks for the (clearer) update.

@nlohmann
Copy link
Owner

Fixed by merging #1441.

@StormTrooper
Copy link

Is it possible to push this fix into a release. Its been fixed on the develop branch but Kodi do not want to point to develop branch.

Maybe a 3.5.1 version? Otherwise for OSMC we have to use a patched fork of vfs.sftp to point to the develop version of nlohmann-json which is not ideal.

@nlohmann nlohmann added this to the Release 3.6.0 milestone Mar 17, 2019
@nlohmann
Copy link
Owner

It will be part of 3.6.0. I hope to make the release by tomorrow.

@nlohmann
Copy link
Owner

@phunkyfish
Copy link
Author

Amazing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants