Point to develop branch of nlohmann-json which uses cmake 3.1 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not keen on moving from a stable to a development branch. Have you asked the maintainers when the next release might be? Otherwise a patch in the meantime would be a better option. |
|
nlohmann/json#1498 - question on next release |
|
Thanks for opening this with the upstream dependency's repository. We have been testing pvr.vuplus with Debian Stretch's version of cmake (3.7.2) without issue for some time. It was only recently we noticed that the depended version constraint has been relaxed upstream. |
|
No problem. Here’s hoping the next release happens soon. |
|
Closing PR and moving issue instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSMC Leia builds are failing due to nlohmann-json v3.5.0 requiring cmake minimum version 3.8
OSMC uses cmake 3.7.2
nlohmann-json develop version has relaxed the requirements on cmake to v3.1
nlohmann/json@e8b6b7a
With below commit the builds are working again.
@samnazarko