Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression tests for MSVC #1543

Closed
nlohmann opened this issue Mar 23, 2019 · 3 comments · Fixed by #1570
Closed

Add regression tests for MSVC #1543

nlohmann opened this issue Mar 23, 2019 · 3 comments · Fixed by #1570
Assignees
@nlohmann
Labels
platform: visual studio related to MSVC release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.7.0

Comments

@nlohmann
Copy link
Owner

We recently had two regressions in MSVC:

It would be great if someone with experience with MSVC could add regression tests for these issues.
@nlohmann nlohmann added platform: visual studio related to MSVC state: help needed the issue needs help to proceed labels Mar 23, 2019
@nickaein
Copy link
Contributor

I'll give it a try.

@nickaein nickaein mentioned this issue Apr 17, 2019
Merged
4 tasks
@nickaein
Copy link
Contributor

I've created an PR to fix this issue. For checking whether Windows.h can cause any troubles, there are two approaches that I have discussed.

@stale
Copy link

stale bot commented May 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label May 17, 2019
@nickaein nickaein mentioned this issue May 23, 2019
Closed
@stale stale bot closed this as completed May 24, 2019
@nlohmann nlohmann added release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation and removed state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated state: help needed the issue needs help to proceed labels Jun 24, 2019
@nlohmann nlohmann added this to the Release 3.6.2 milestone Jun 24, 2019
@nlohmann nlohmann modified the milestones: Release 3.6.2, Release 3.7.0 Jul 9, 2019
@nlohmann nlohmann added this to the Release 3.7.0 milestone Jul 28, 2019
@nlohmann nlohmann self-assigned this Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
platform: visual studio related to MSVC release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.7.0
Development

Successfully merging a pull request may close this issue.

Regression tests for MSVC nickaein/nlohmann-json
2 participants
@nlohmann @nickaein