Failed to build with <Windows.h>

[ilgiz-badamshin]

Related to #1514

• What is the issue you have?
  Failed to build if <Windows.h> is included:

C4003: not enough arguments for function-like macro invocation 'max'

Code:
assert(p2 <= std::numeric_limits<std::uint64_t>::max() / 10);
should be:
assert(p2 <= (std::numeric_limits<std::uint64_t>::max)() / 10);

[nlohmann]

Thanks for reporting! Could you please check if 9d6ab90 fixes the issue?

[ilgiz-badamshin]

Build succeeded.

Thanks.

[nlohmann]

---

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

• ✨ New Feature
• 🐛 Bug Fix
• ⚡️ Improvement
• 🔨 Further Change
• 🔥 Deprecated function

Description

• Fixed a compilation error when <Windows.h> was included. Failed to build with <Windows.h> #1531

---

[dvj]

If you want to try to avoid this type of regression in the future, a test that includes windows.h (a la https://github.com/CLIUtils/CLI11/pull/145/files#diff-da661fc0dc16940197d2112712cbf2bb) could be added as well!