Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since re2c is often ignored in pull requests, it may make sense to make a contributing.md file #175

Closed
whackashoe opened this issue Jan 11, 2016 · 6 comments

Comments

@whackashoe
Copy link
Contributor

Would save people a bit of time, plus could be useful for keeping code the same style and such too.

@nlohmann
Copy link
Owner

Thanks @whackashoe for noting this. Each time I commented on pull requests, I thought about writing such a file, but I always forget afterward. It's good to have this on the list here now. I shall try to merge this with the FAQ (#163).

nlohmann added a commit that referenced this issue Jan 13, 2016
@nlohmann
Copy link
Owner

I added some guidelines. Please tell me what you think!

@nlohmann nlohmann added the state: please discuss please discuss the issue or vote for your favorite option label Jan 13, 2016
@gregmarr
Copy link
Contributor

Looks good. There are a couple places under files to change bullet 1 where you use src.json.hpp instead of src/json.hpp.

@nlohmann
Copy link
Owner

Ooops. I fixed it.

@nlohmann nlohmann added this to the Release 1.0.1 milestone Jan 13, 2016
@twelsby
Copy link
Contributor

twelsby commented Jan 19, 2016

This is a small thing but perhaps add something about testing under Valgrind as occasionally (as I found out to my surprise in pull request #183) it can yield different results to a vanilla run.

nlohmann added a commit that referenced this issue Jan 20, 2016
@nlohmann nlohmann removed the state: please discuss please discuss the issue or vote for your favorite option label Jan 20, 2016
@nlohmann
Copy link
Owner

Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants