Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for JSONC #2061

Closed
tjohnsonhvac opened this issue Apr 23, 2020 · 1 comment · Fixed by #2212
Closed

Add support for JSONC #2061

tjohnsonhvac opened this issue Apr 23, 2020 · 1 comment · Fixed by #2212
Labels
kind: enhancement/improvement solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.9.0

Comments

@tjohnsonhvac
Copy link

We use use json files for configuration. It would be nice to be able to add comments to those configuration files.

https://changelog.com/news/jsonc-is-a-superset-of-json-which-supports-comments-6LwR
@nlohmann
Copy link
Owner

This library will not support non-conforming extensions such as comments. See https://github.com/nlohmann/json#comments-in-json for an explanation.

@nlohmann nlohmann added the solution: wontfix the issue will not be fixed (either it is impossible or deemed out of scope) label Apr 23, 2020
@nlohmann nlohmann mentioned this issue Jun 23, 2020
Merged
@nlohmann nlohmann added solution: proposed fix a fix for the issue has been proposed and waits for confirmation and removed solution: wontfix the issue will not be fixed (either it is impossible or deemed out of scope) labels Jun 23, 2020
@nlohmann nlohmann reopened this Jun 23, 2020
@nlohmann nlohmann added this to the Release 3.8.1 milestone Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: enhancement/improvement solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging a pull request may close this issue.

Add option to ignore comments in parse/accept functions nlohmann/json
2 participants
@nlohmann @tjohnsonhvac