-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails with clang-cl due to override of CMAKE_CXX_COMPILER(?) #2384
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Help would be greatly appreciated... |
I've met the same issue here with Clang-11. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Maybe related: #2343 |
Thanks for reporting, and sorry for the late response. As written in #2343 (comment), the goal of I am confused why setting variable
Can you please re-try with the latest |
Dear @nlohmann thanks for the kind help! Indeed its like you say, the problem comes up only with v3.9.1 (current latest release), but not with the latest |
I'm trying to build json 3.9.1 with clang-cl 10.0.0 (from Visual Studio 2019 current latest) on MSVC. The build fails for me already in the cmake configure stage. I could track the problem down to a line in
cmake/download_test_data.cmake
that overrides the detected compiler:json/cmake/download_test_data.cmake
Line 51 in 1bcabd9
I'm under the impression that the semicolon surrounding
... MSVC_VERSION=${MSVC_VERSION}; ...
is interpreted byclang-cl
as an end-of-line. There are related reports on the internet that would indicate this being the problem.Here is the output from cmake:
Here are a few examples of the failling build:
I'm a bit puzzled what the override of
CXX_VERSION_RESULT
is used for. When I remove this line everything seems to work fine... is there a good reason to enforce an override?The text was updated successfully, but these errors were encountered: