Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio Visual Assist code issues reported by VA code inspection of file json.hpp #2615

Closed
Andreas-Schniertshauer opened this issue Jan 27, 2021 · 1 comment
Closed

Visual Studio Visual Assist code issues reported by VA code inspection of file json.hpp #2615

Andreas-Schniertshauer opened this issue Jan 27, 2021 · 1 comment
Assignees
@nlohmann
Labels
confirmed kind: bug release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.10.0

Comments

@Andreas-Schniertshauer
Copy link

Code Issues reported by VA in json-3.9.1.zip in file json.hpp:
Line 3947 Unnecessary string initialisation: Member empty_str in template<typename IteratorType> class iteration_proxy_value
Line 4950 Unnecessary use of else after early exit: in class iterator_input_adapter in function get_character
Line 10621 Unnecessary use of else after early exit: in function bool sax_parse_internal(SAX* sax)
Line 14951 Unnecessary use of else after early exit: in function inline int find_largest_pow10(const std::uint32_t n, std::uint32_t& pow10)
nlohmann added a commit that referenced this issue Jan 27, 2021
@nlohmann
🚨 fix warnings #2615
ffdeb77
@nlohmann nlohmann self-assigned this Jan 27, 2021
@nlohmann nlohmann added the solution: proposed fix a fix for the issue has been proposed and waits for confirmation label Jan 27, 2021
@nlohmann
Copy link
Owner

The issue should be fixed with ffdeb77 in branch issue2615. @Andreas-Schniertshauer can you please check?

@nlohmann nlohmann added this to the Release 3.9.2 milestone Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
confirmed kind: bug release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.10.0
Development

No branches or pull requests
2 participants
@nlohmann @Andreas-Schniertshauer