Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unused parameter error/warning #2706

Closed
raduteo opened this issue Apr 9, 2021 · 0 comments · Fixed by #2707
Closed

unused parameter error/warning #2706

raduteo opened this issue Apr 9, 2021 · 0 comments · Fixed by #2707
Assignees
@nlohmann
Labels
release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.10.0

Comments

@raduteo
Copy link
Contributor

raduteo commented Apr 9, 2021

I just picked up the json diagnostic option which is a great new addition btw, but I am currently seeing this error (can be made warning) when building in release mode (basically cassert(foo) is being eliminated by the pre-processor leading the error below:

json/single_include/nlohmann/json.hpp:18131:32: error: unused parameter 'check_parents' [-Werror=unused-parameter]
18131 | void assert_invariant(bool check_parents = true) const noexcept
| ~~~~~^~~~~~~~~~~~~~~~~~~~

Thank you again for all the vibrant support
raduteo added a commit to raduteo/json that referenced this issue Apr 9, 2021
@raduteo
Update json.hpp
e8dbd7b 
Proposed fix for nlohmann#2706
raduteo added a commit to raduteo/json that referenced this issue Apr 9, 2021
@raduteo
Update json.hpp
374a063 
Proposed fix for nlohmann#2706
@raduteo raduteo mentioned this issue Apr 9, 2021
Merged
4 tasks
@nlohmann nlohmann linked a pull request Apr 23, 2021 that will close this issue
Update json.hpp #2707
Merged
4 tasks
@nlohmann nlohmann self-assigned this Apr 23, 2021
@nlohmann nlohmann added release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels Apr 23, 2021
@nlohmann nlohmann added this to the Release 3.9.2 milestone Apr 23, 2021
nickaein pushed a commit to nickaein/nlohmann-json that referenced this issue Apr 29, 2021
@raduteo
Update json.hpp
79a5405 
Proposed fix for nlohmann#2706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.10.0
Development

Successfully merging a pull request may close this issue.

Update json.hpp raduteo/json
2 participants
@nlohmann @raduteo