Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation error with JSON_DIAGNOSTICS enabled #3717

Closed
1 of 2 tasks
Evil-Spirit opened this issue Aug 30, 2022 · 1 comment · Fixed by #3719
Closed
1 of 2 tasks

Compilation error with JSON_DIAGNOSTICS enabled #3717

Evil-Spirit opened this issue Aug 30, 2022 · 1 comment · Fixed by #3719
Labels
kind: bug solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.11.3

Comments

@Evil-Spirit
Copy link

Description

When JSON_DIAGNOSTICS defined, the following compilation error appears:

execeptions.hpp:119 accumulate is not member of std

Reproduction steps

#define JSON_DIAGNOSTICS
#include "nlohmann/json.hpp"

Expected vs. actual results

No compilation error should be

Minimal code example

No response

Error messages

No response

Compiler and operating system

Windows MSVC

Library version

latest

Validation
Evil-Spirit added a commit to Evil-Spirit/nlohmann-json that referenced this issue Aug 30, 2022
@Evil-Spirit
nlohmann#3717: fix compilation error: "execeptions.hpp:119 accumulate…
c759e28 
… is not member of std"
falbrechtskirchinger added a commit to falbrechtskirchinger/json that referenced this issue Aug 30, 2022
@falbrechtskirchinger
Add missing <numeric> include
90ed26d 
Fixes #nlohmann#3717.
Merged
@falbrechtskirchinger
Copy link
Contributor

The include for std::accumulate is indeed missing. Fixed by #3719. Thanks.

@nlohmann nlohmann added this to the Release 3.11.3 milestone Aug 30, 2022
@nlohmann nlohmann added the solution: proposed fix a fix for the issue has been proposed and waits for confirmation label Aug 30, 2022
@nlohmann nlohmann mentioned this issue Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: bug solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.11.3
Development

Successfully merging a pull request may close this issue.

Add missing <numeric> include falbrechtskirchinger/json
3 participants
@nlohmann @falbrechtskirchinger @Evil-Spirit