-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in cmake/test.cmake
#3902
Labels
good first issue
kind: bug
solution: proposed fix
a fix for the issue has been proposed and waits for confirmation
Milestone
Comments
Good catch! |
Hi @nlohmann can you please assign me |
Go ahead! |
Hi @nlohmann I'm new to CMake can you suggest to me how to setup development environment on my local machine and how to run the project |
No, I cannot assist you there. Please let me know if I should un-assign you. |
Hey @nlohmann, can I do it? |
Go ahead! |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
kind: bug
solution: proposed fix
a fix for the issue has been proposed and waits for confirmation
Description
At line 260 in
cmake/test.cmake
there is this codeThe conditional check
The first condition
if(sizeof_size_t
is always TRUE, since it is comparing against the string value "sizeof_size_t". To check if the string is empty (meaning check_type_size could not return a value for size_t) it should beIf for some reason the size of size_t is unknown (for example, using exotic toolchains where stddef.h might not be visible during the initial cmake evaluation) this will cause the invocation of
cmake
to fail.Reproduction steps
Replace the call to
check_type_size
withExpected vs. actual results
Running
cmake .
should not fail.Minimal code example
No response
Error messages
The text was updated successfully, but these errors were encountered: