Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For a header-only library you have to clone 214MB #482

Closed
frobware opened this issue Mar 3, 2017 · 1 comment · Fixed by #2081
Closed

For a header-only library you have to clone 214MB #482

frobware opened this issue Mar 3, 2017 · 1 comment · Fixed by #2081
Assignees
@nlohmann
Labels
release item: 🔨 further change solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.8.0

Comments

@frobware
Copy link

frobware commented Mar 3, 2017 •
edited

It would be nice if the tests and benchmark data could be separated from the include file. I just added this as a git submodule and discovered the clone is 214MB.
@gregmarr
Copy link
Contributor

gregmarr commented Mar 3, 2017

#96

@nlohmann nlohmann added the solution: duplicate the issue is a duplicate; refer to the linked issue instead label Mar 3, 2017
@nlohmann nlohmann closed this as completed Mar 3, 2017
@nlohmann nlohmann mentioned this issue Apr 15, 2017
Closed
@tuananh tuananh mentioned this issue Jun 15, 2017
Closed
@nlohmann nlohmann mentioned this issue Sep 8, 2017
Closed
@nlohmann nlohmann mentioned this issue Apr 23, 2018
Closed
@nlohmann nlohmann reopened this May 4, 2020
@nlohmann nlohmann linked a pull request May 4, 2020 that will close this issue
Use external test data #2081
Merged
@nlohmann nlohmann mentioned this issue May 4, 2020
Merged
@nlohmann nlohmann self-assigned this May 4, 2020
@nlohmann nlohmann added this to the Release 3.8.0 milestone May 4, 2020
@nlohmann nlohmann added release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.8.0
Development

Successfully merging a pull request may close this issue.

Use external test data nlohmann/json
3 participants
@nlohmann @frobware @gregmarr