Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warning, see issue #755 #1222

Closed
wants to merge 2 commits into from
Closed

Fix compiler warning, see issue #755 #1222

wants to merge 2 commits into from

Conversation

zakalibit
Copy link

@zakalibit zakalibit commented Sep 1, 2018

[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]


Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.8 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
  • Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

It works with signed and unsigned  integers.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 53420cb on zakalibit:develop into d713727 on nlohmann:develop.

@nlohmann
Copy link
Owner

nlohmann commented Sep 8, 2018

Please run make amalgamate to create a single header and update the PR accordingly.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make amalgamate is missing.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make amalgamate.

@nlohmann
Copy link
Owner

@zakalibit Could you update the PR with respect to #1222 (review)?

@nlohmann nlohmann closed this in 4e54c9a Sep 29, 2018
nlohmann added a commit that referenced this pull request Sep 29, 2018
@nlohmann
Copy link
Owner

I added fix with amalgamation myself. Thanks a lot for the fix!

@nlohmann nlohmann added this to the Release 3.2.1 milestone Sep 29, 2018
@nlohmann nlohmann self-assigned this Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants