Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1971 (memory leak in basic_json::push_back) #2025

Merged

Conversation

ArtemSarmini
Copy link
Contributor

@ArtemSarmini ArtemSarmini commented Apr 2, 2020

Fixes leak in basic_json::push_back(basic_json&&). Old code incorrectly assumed that std::move moves, which is not always the case. basic_json move constructor marks argument as null anyway, so that line of code was redundant.
I also added valgrind-oriented unit test to address such situation.


Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
  • Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

test/src/unit-allocator.cpp Outdated Show resolved Hide resolved
atanisoft added a commit to atanisoft/ESP32CommandStation that referenced this pull request Apr 6, 2020
@ArtemSarmini
Copy link
Contributor Author

What do I do with this? https://travis-ci.org/github/nlohmann/json/jobs/672497870

E: Unable to locate package g++-9
E: Couldn't find any package by regex 'g++-9'

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Apr 10, 2020
@nlohmann nlohmann added this to the Release 3.7.4 milestone Apr 10, 2020
@nlohmann nlohmann merged commit ea0a7c7 into nlohmann:develop Apr 10, 2020
@nlohmann
Copy link
Owner

Thanks!

@nlohmann
Copy link
Owner


🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description


@ArtemSarmini
Copy link
Contributor Author

Glad to help.

@ArtemSarmini ArtemSarmini deleted the issue-1971-basic_json-push_back branch April 13, 2020 12:46
atanisoft added a commit to atanisoft/ESP32CommandStation that referenced this pull request May 26, 2020
commit 10d13ebc8ffe9b46ce14967b834eef5705554068
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue May 26 08:36:12 2020 -0700

    todo update

commit 1f88fee9ad79e548af2efa86eb06b35b8a385b0c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue May 26 08:35:39 2020 -0700

    :pencil: Add pin validations

commit 1768e49dbaba2165fa5b3f6a4b2f1a17a4ae9487
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue May 26 07:31:15 2020 -0700

    :construction: Adding RailCom driver.

    This is not fully used yet but will soon be.

commit eec62ced705899e341832943c17b522979d6bc12
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue May 26 06:59:49 2020 -0700

    :pencil: Display only pool size and not free items

commit 2eaf4ea4598b1803dba1f320b34214c5238cae28
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon May 25 16:58:08 2020 -0700

    :pencil: Move RMTTrackDevice and MonitoredHBridge into esp32cs namespace

commit a6ed0262ccf30090a92040f3a16eed7cfef08b2c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 23 16:40:36 2020 -0700

    :construction: Correct RailCom pin definitions, clear BRAKE pin on enable and set it on disable.

commit 473d900710270026902e6b31ed7a74b8530deb02
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 23 16:24:38 2020 -0700

    :sparkles: Add /version http endpoint to return basic CS app data as json

commit 552a04345fd1cb23c579d814b917ddba1ecf5af0
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 23 11:35:01 2020 -0700

    :pencil: disable factory reset on pcb by default.

commit 284d2b3581f265d37b295fd3169b49020a929a2b
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 23 11:28:52 2020 -0700

    :pencil: set direction correctly for tex.

commit 9567a339a570c649c86e548f46b056fbdaf7c40a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 23 11:24:31 2020 -0700

    :ambulance: Correct the loco speed in json output.

commit 7c6fa3e7637f60532639f92c356228f74e92a2c0
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 23 06:16:18 2020 -0700

    :fire: Disable NeoNextion build bits
    :fire: Remove ESP32CommandStation.h

commit fa9b076008581df213cbaa11f87f847dcb259136
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 23 05:51:55 2020 -0700

    :fire: Remove integrated Nextion from v1.5.0

commit 8894126fe484e4468bc85b851f67d1556329429a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri May 22 19:22:38 2020 -0700

    :ambulance: Set loco direction after speed...
    :ambulance: Only retrieve locos that are active from web.

commit e93ebf6dafa2ee5d024c9f80acb8797c25f360d0
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri May 22 09:33:54 2020 -0700

    :pencil: Small changes to SD log entries.

commit 96bda12fc2a338951506c142a305b420ae623d3d
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri May 22 09:33:20 2020 -0700

    :ambulance: Use DCC_128 instead of DCC_128_LONG_ADDRESS.

    By forcing long address form the packets were being rejected by the decoders.

commit 0077d6ea3119a56898246823501a7b3b1c51a273
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu May 21 15:24:31 2020 -0700

    :construction: adjust config options for better clarity

commit 80187f56bbc1d35447df0557cb28811ca496f210
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu May 21 15:24:11 2020 -0700

    :construction: rework nextion so it is closer to compiling again

commit 9800c4fc05056dd63236982e12dffc6cf1f70593
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu May 21 14:52:54 2020 -0700

    :fire: Remove LocoNet support as it is not working or supported (currently)

commit 19752251a9a50dc1bbd439ef6e6fcb4a48ec750f
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu May 21 13:27:21 2020 -0700

    :ambulance: remove extra repeat being sent for the dcc packets.

commit 55acea106ab50b1a1e0df5262f21916a1b715fc2
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu May 21 07:23:01 2020 -0700

    :pencil: Reduce stack size for CAN TX/RX/Bridge to 2k

commit 2cd27dd17f0ba831737bc7c8296a8bf58ffd2060
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu May 21 07:22:33 2020 -0700

    :ambulance: Set DCC speeds by MPH rather than speed steps.
    :tractor: Move DCC++ protocol command declarations out of DCCppProtocol.h.
    :ambulance: validate required number of arguments provided for DCC++ protocol commands.

commit 9dafd97d9e803556683aff24605848977f4deae2
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu May 21 06:07:33 2020 -0700

    :pencil: Revert bit test in Velocity::set_dcc_128()

commit ead8df64d6d6160f4a35709c81c435ed1b493054
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed May 20 10:03:27 2020 -0700

    :ambulance: Change how loco speed is sent to active locos.
    :ambulance: fix loco defaulting to reverse for a forward movement request

commit dfb6c718c021ed5348ff6b6f34730a930e070f5f
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue May 19 15:55:46 2020 -0700

    update ignore list, update todo list

commit 9a106b17a963a8a665c4291d1a0e82749f7e9209
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue May 19 15:53:53 2020 -0700

    :construction: Add value checking for turnout address
    :ambulance: Add saving of reconnect flag

commit 9c62ca08d5e38808ebfea6b523d061773f0f17d0
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue May 19 15:51:48 2020 -0700

    :pencil: Expose config option for auto-idle flag (default off)

commit c9ef7e467ca44e67596100a9df29120ebb6b308c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue May 19 14:48:43 2020 -0700

    :pencil: Increase number of open files

commit 7a0d88bdcc1b6f4ff7836d8613b400d8d25d268c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue May 19 14:31:54 2020 -0700

    :tractor: Move CanBridge instance to it's own task.

    This allows the HW-CAN to work until I can rewrite it to plugin directly to the hub instead of using bridge and multiple tasks.

commit 319fcbc231b092f1664f6895843fc969826d8124
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue May 19 07:36:15 2020 -0700

    :ambulance: only send prog response when required.

commit 7991e7071c2bad83426a6439d528163a1c809025
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun May 17 07:40:06 2020 -0700

    :tractor: Add parameter validation to DCC++ parser for <T> and <Tex>.
    :tractor: Fix DCC++ index generation (always recalculates from one)

commit 1b599e3bbc9158da17827ee841a50afd70b23b8b
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun May 17 07:35:42 2020 -0700

    :tractor: switch to JsonResponse.
    :ambulance: Use STATUS_NO_CONTENT for PUT/DELETE so jquery processes it correctly.
    :tractor: Adding spinner to PUT/DELETE calls.

commit d496126cd1768c13fac525d54cb8eb979a1bf9fe
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun May 17 07:30:17 2020 -0700

    :pencil: Add json response type wrapper

commit c62635d4ada575604f0c31f1632ea06f992bb3f6
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun May 17 07:30:04 2020 -0700

    :pencil: OpenMRN sync

commit 56708082370f38399a362fb430c845c2c2054cd0
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 16 11:32:16 2020 -0700

    :tractor: working on sorting dcc accessory addresses

commit 0fac575bade11690513b358bcaeb5b50eb54b175
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 16 09:22:21 2020 -0700

    :tractor: defer the cleanup of http flows

    instead of using delete_this() move the cleanup to be done from a throw away executable

commit 412bb95a933987b999c0b6e0a4ccbc5925e1cb38
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 16 09:08:26 2020 -0700

    :pencil: Correct bad config var reference.

commit 2523e6245d224405485696903ee37a19ca7146d1
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 16 09:07:47 2020 -0700

    :tractor: Reduce the socket listen backlog to three

    It seems the esp32 is not able to drain the backlog when the listener socket is flooded with requests (ie: first load of webpage)

commit 91eac415778dfdce8c4a1ecac56322c343662946
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 16 08:21:15 2020 -0700

    :pencil: increase number of requests per http connection

commit 0dc830d5d21a82ef81e09244bc2af78b1563b668
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 16 08:20:58 2020 -0700

    :pencil: OpenMRNLite sync

commit 761ab5545dfffada229af90e0f2d6ea690276829
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 16 06:50:21 2020 -0700

    :pencil: Adjust how turnout addresses are decoded/encoded.

commit bd9cd44e4bf07ede55084fbfa2f11f9d6c05ff17
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri May 15 20:24:38 2020 -0700

    :pencil: ensure the direction is set correct for locos

commit e78ba11905c40c45e440b7066c3383e00c367082
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri May 15 11:31:17 2020 -0700

    :pencil: use board index when board address is zero.

commit b78816a7a52aa202bf4635a1ce633210acd7fe1e
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri May 15 11:28:43 2020 -0700

    :pencil: ensure turnout address decoding does not go below zero

commit 09f41d28901d1ac31d630587c36cd23849c62b56
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri May 15 08:29:17 2020 -0700

    :ambulance: Fix turnout address functionality

commit ce699b1df5cb5be961e4cb6df803ab09ed10f251
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri May 15 07:20:30 2020 -0700

    :pencil: Minor updates to config options

commit fcf36f18803b84f4ca5037f3fb2aff2c7db39c88
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu May 14 15:30:29 2020 -0700

    :pencil: Adjust flash command for readme

commit 9430f54ac852dd2deef1bce68b1da5521f04fb8d
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu May 14 15:30:13 2020 -0700

    :pencil: Prevent subsequent triggering of select if already triggered.

commit 3e4e46ac5e0be14a85c322ec61362e97b3e5a92e
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu May 14 15:29:22 2020 -0700

    :ambulance: Bump socket listener stack to 3k

commit b0e52425db033faffc9ae9fdfed33654b78c2067
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu May 14 15:29:08 2020 -0700

    :pencil: Rearrange some config options for clarity

commit be3ce7ea45e1fdca9bc0fe2356a23b6d298ae12c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed May 13 07:21:54 2020 -0700

    :green_heart: Remove quotes on defaults

commit 733f6fb6e386f5096ef3aec0eef065fb044fea57
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed May 13 07:18:54 2020 -0700

    :tractor: adjusting default mbedTLS config

    disabling TLS support (not used today) and ensuring ECP is enabled

commit c370a92c84e7ef806e2f14c57aa8ddc193465b83
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed May 13 06:09:06 2020 -0700

    :pencil: Simplify event send logic

commit 5c76512db2cc7da34168c8531227ae090af2d484
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed May 13 06:08:28 2020 -0700

    :pencil: Move h-bridge polling init later in the startup

commit 41b2f7ad5f57c9ff29a14fc897fe5f7e9fb4c3a9
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed May 13 05:27:48 2020 -0700

    :pencil: Skip reboot on initial seeding of LCC can config

commit 35f35e3873838c10e90dc0d72047fdcee6503cb6
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed May 13 05:27:23 2020 -0700

    :pencil: Correct KConfig default (not enabled by default)

commit 07d52b678a95fa9c30b94ed4b0330bd602f480bc
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue May 12 09:03:33 2020 -0700

    :pencil: Hide OPS_HBRIDGE_MAX_MILLIAMPS and PROG_HBRIDGE_MAX_MILLIAMPS.
    :pencil: Clarify OPS_HBRIDGE_LIMIT_MILLIAMPS and PROG_HBRIDGE_LIMIT_MILLIAMPS

commit 7243871559b7785695af8ecfa607228bc4bf6ba6
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue May 12 09:02:43 2020 -0700

    :ambulance: Fix factory reset button on webpage

    Previously the factory reset button would only clear LCC and WiFi settings. It should be force clearing all persistent data instead.

commit 2905a7fe0cc78c571028bb859687797bae9fa6e1
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon May 11 10:10:21 2020 -0700

    :pencil: rework shutdown of wifi task to block until it is down.

commit 2b58d5d248bc261fc9b945e707138fa1a9494649
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon May 11 08:46:09 2020 -0700

    :ambulance: Fix restart json payload.
    :pencil: Ensure background tasks have time to complete before shutdown.

commit 9ffc10b10181d551534ab6a92afdb75221084c90
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon May 11 07:19:13 2020 -0700

    :pencil: Ensure events do not block reporting of ACK

commit 21b204a7a5ecc6a5f66f48e998dad55a2b5c2664
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun May 10 15:26:05 2020 -0700

    :pencil: todo update

commit 478e16b783269eb63e5ffdf1568ea27d1acd5030
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun May 10 15:19:27 2020 -0700

    :pencil: Correct log msg for FDI and move to VERBOSE

commit 068f2178957ddff791accb9b837ba1f7144ecc42
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun May 10 09:01:34 2020 -0700

    :ambulance: Fixed changing of loco name after creation

commit 3a7cd905b173dada6249f300e0a62ee2964e3fb1
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun May 10 09:01:09 2020 -0700

    :pencil: OpenMRN sync

commit 956ca7536b95060a61848fb2b46af58d7a8b86bf
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun May 10 06:52:17 2020 -0700

    :pencil: Switch to new macro OVERRIDE_CONST_DEFERRED

commit 4e7d899530d188b19e2484fd05459d8f6f5f998a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun May 10 06:51:03 2020 -0700

    :pencil: Add OVERRIDE_CONST_DEFERRED macro

commit 4dad9db9cc4355fa8453ff9e96a22e9723aa4e3e
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun May 10 06:50:29 2020 -0700

    :pencil: Move stack size to constants

commit 32f78058541475c35eac533e1fb00aad184129bc
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 9 07:35:41 2020 -0700

    :pencil: Add debug logging to train-search

commit a6dd6fba46d5beb77f06520f48a6dbad8335062a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 9 07:02:46 2020 -0700

    :ambulance: Add missing typecast for packet printing

commit 17dec749a6ddd0955ab2819c9de2a6555cd62599
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri May 8 14:49:14 2020 -0700

    :tractor: Known (but inactive) locos can not be requested by throttles

commit 1f16d8279964f9879347c30fe28e6ae4307fbf46
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu May 7 08:31:56 2020 -0700

    :ambulance: Fix being able to disable idle/default on throttle

commit 819f21005eb097cdd1aa6d11a2db3f91ca642ebd
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu May 7 05:55:58 2020 -0700

    :pencil: Combine log output for RMT config

commit c0b68096ed5f5eed5ee4ea1ad9adbd9b54f6e345
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu May 7 05:50:59 2020 -0700

    :tractor: Added url_encode method and clarified comments on url_decode

commit 81f069a0f7dd59cf89d8f7614437f9fe128bd95b
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed May 6 13:29:42 2020 -0700

    :ambulance: Correct the accessories decoder packets

    When throwing a turnout it should send address + 1 and closing a turnout address + 0.

commit 4966cbd41cddea95499a49575b73e0631f97e0cb
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed May 6 05:53:19 2020 -0700

    :tractor: Adding automatic load of "idle" trains on startup
    :fire: Remove support for legacy roster file.

commit 6303045bcf597dcab175fe1fe957871619e27b76
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue May 5 08:14:32 2020 -0700

    :tractor: Drop legacy "board : index" turnout type

commit 7662d85c1ad9b8ebdea1a2e37055fe0d8ff408ac
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon May 4 14:52:41 2020 -0700

    :pencil: dump dcc packet data when verbose is enabled for turnouts

commit 875764d94bc31266c5248d32cf042e4e44d9e5d4
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun May 3 07:58:22 2020 -0700

    :tractor: Implement loco roster entry deletion.

commit 90b5e6b9bcfcc37ad77d447d55ad53957c58bbf7
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun May 3 07:15:33 2020 -0700

    :ambulance: Fix bug in urldecode of form data

    When entering reserved characters in the name of locomotives (ie: #3) the name was being decoded incorrectly as '33'.

    Extracted the decoding to a utility method so it could be used also on the http headers which may also be encoded.

commit c3c34f1af37b9294459f999c265fc2c67e351ad8
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat May 2 06:13:14 2020 -0700

    :pencil: Silence connection messages by default.

commit 02586cc845aff80e331aa2180b403eb5d6a96c73
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri May 1 20:40:05 2020 -0700

    :pencil: cleanup vtable entries for httpd

commit 0ccb03051e041485cfedda687c96e0b6fb595944
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri May 1 20:25:22 2020 -0700

    :pencil: Adding request payload size to request_complete()

commit 54ff4e1717ebf314ef3fa2f7bcf87c6ccef29a9e
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Apr 29 06:44:07 2020 -0700

    :pencil: use SW version config param and app version

commit 5aa202db2c638015ded18c6e9058f2284c0d713f
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Apr 29 06:34:38 2020 -0700

    :pencil: Use unique name for http socket

commit 45a9b5169240691d3a9dff0651bbfa638ff56f5d
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Apr 29 06:19:54 2020 -0700

    :ambulance: Hide sensors/outputs when disabled via config

commit 8ccf9270e01e9056875ec429f8a33423d3b3937c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Apr 29 06:12:42 2020 -0700

    :pencil: Named socket listener threads

commit 78eaa0a33c1c9996e0e7697afbff34da76dd6306
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Apr 29 05:55:39 2020 -0700

    :pencil: Add option to not restart on SSID connect failure.

commit 7e85e3e39b985e5f7ee61853500d9180ca40705a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Apr 28 09:42:29 2020 -0700

    :pencil: Remove RailCom short pin definition.

    This pin is not actively used by the ESP32 and likely doesn't need to be used directly as it should be disabling the FETs as part of the schematic which will cause the RailCom reads to fail (or otherwise be corrupted) which will cause them to be discarded. The short detection outside of the cutout will detect and disable track output if the short persists.

commit 7774924e2492ae0738485af3a6e92b1f83cd4f44
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 27 07:55:52 2020 -0700

    :pencil: Move httpd init to app_main
    :pencil: switch to using stack helper methods

commit 455dd55795ffab868af30343e77a7cf7f521e09a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 27 07:55:13 2020 -0700

    :pencil: Expose stack helper methods

commit f21553c402d3af4eb43ae8086d3378fb8c146b3f
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Apr 22 08:32:30 2020 -0700

    :tractor: Enable LCC CAN (partially works)

commit adbeb0a4b5b6d7e43459d1012075e4bae65e4784
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 20 06:49:09 2020 -0700

    :pencil: Add debug log for reconfigure_station.
    :ambulance: add encoding for non-ASCII ssid names in scan result.

commit 6a28cf633437a9fefacad032007455d033a1892b
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 20 05:17:08 2020 -0700

    :pencil: Set default LED data pin

    Due to a bug in the Espressif IDF plugin for VSCode a default value is required for numeric data types to be able to use the GUI menuconfig utility.

commit a639943e8c3e1f6634e02fe88c0f7826ba0a1fa0
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Apr 19 21:30:35 2020 -0700

    :pencil: remove include (for now)

commit 7906125b947621fa24f1455d14753baed801024a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Apr 19 21:25:35 2020 -0700

    :pencil: mask off the CAN adapter (for now)

commit 2129fddc2b8571c2b75023b4ea39e00f8d990cf2
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Apr 19 20:50:12 2020 -0700

    :pencil: Add missing include

commit 5825c7cd024f7023385bf0f67103b141e5707514
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Apr 19 20:43:36 2020 -0700

    :tractor: Split up ConfigurationManager

    This helps the build time some and modularizes the config a bit.

commit 0b22c7071d43fb7038bc6bf78bd6e4bef2f17ab3
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Apr 19 15:36:07 2020 -0700

    :ambulance: Fix missing includes

commit a03143207196dbb0591f8b34c91d6c4b338c69f7
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Apr 18 06:25:41 2020 -0700

    :pencil: Remove ref to ConfigurationManager for SSID name

commit 75025b1e5d0044d2283e3594ed0a869fc2b0bc72
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Apr 18 06:08:49 2020 -0700

    :pencil: Add missing include

commit 3cb78dce4f08bbd6c4c96feca3a183f0b0c6ab98
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Apr 17 07:08:56 2020 -0700

    :pencil: switch to event IP payload

commit 5330b327d7d5a849e11a68c92426365e2f81b483
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Apr 17 07:07:33 2020 -0700

    :pencil: Switch to event IP payload

commit 49c3a53df823cbf49d590969316f52a2879127b0
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Apr 17 06:04:38 2020 -0700

    :tractor: Moved include references to where they are actually used.

commit 2dd19adeaf42ca914f384b10d49ddb69b4b1648c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Apr 14 16:05:34 2020 -0700

    :tractor: Move S88 code to use openlcb::Polling
    :ambulance: Fix S88 persistence layer

commit 7c09e629e67ab231286ce5656e5ff90d2b6c6d32
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Apr 14 07:27:03 2020 -0700

    :pencil: Correct comments
    :pencil: Check for instance existance before usage in mDNS APIs.

commit c46e7a8f9c180438226e9d14ded89a97a0a7002e
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Apr 14 07:02:41 2020 -0700

    :pencil: Reduce frequency of LCC node pings

commit 7fd1852a3227e84681b02ae032a564ef73de3713
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Apr 14 07:02:21 2020 -0700

    :ambulance: Shutdown WiFi stack before stopping executors

commit e1abc6e04fd10b93fe879a1149c6870d7e1bc9fa
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Apr 14 06:47:07 2020 -0700

    :ambulance: Prevent more DCC packets from being sent when VFS is shutdown.

commit a023ae2474bcb806e09667ed719d92707cd90a29
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 13 16:45:53 2020 -0700

    :green_heart: Adding missing includes

commit b8164309b5c170d698091118359629acbcd3203d
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 13 16:23:35 2020 -0700

    :pencil: Move constants to Kconfig.projbuild for ease of maintenance

commit 6f1d0af971ba59f065a65e086b0cfe58160f64c0
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 13 16:15:24 2020 -0700

    :pencil: Move ConfigErase, ConfigStore and StatusCommand to DCCppProtocol component.

commit 36b39c598b4974d2e819c216ed77c16f64a17237
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 13 13:40:55 2020 -0700

    :ambulance: Fix S88 pin declarations.

    The pins were configured as inputs rather than as outputs with a default LOW state.

commit 1df8b4706e9ce442726568657bb03828374500eb
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 13 09:16:47 2020 -0700

    :ambulance: Use correct type name for DummyPin

commit 13678e40575152246daf3193a52967b47dbc0240
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 13 07:30:18 2020 -0700

    :pencil: Remove duplicate log output.

commit 55a927f8c8137d9045af9f45deb457ec0c1e19aa
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 13 07:29:35 2020 -0700

    :ambulance: Fix bug with poll_33hz()

    The Notifiable was not being triggered in all cases leading to the h-bridge monitoring stopping after one iteration.

commit 5260d863569eb74397d17baf5725d355e54f274d
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 13 05:50:11 2020 -0700

    :pencil: pull in bug fix for hidden groups in cdi

commit 21ec0ff04eaa1fb9be7af01544a9e702a078e10c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Apr 12 06:17:40 2020 -0700

    :ambulance: Set S88 minimum sensor count to 8.
    :ambulance: Ensure comma is only added to json output when necessary for outputs, remote sensors and s88.

commit 45c17d0843f1ca7285c3d4818fed45a2f3015334
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Apr 12 06:12:34 2020 -0700

    :pencil: When StatusLED is not enabled mask usages

commit 8f03804ba182fea990fe00e64c04904f9055c2c4
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Apr 12 06:11:42 2020 -0700

    :ambulance: Fix h-bridge status reporting

    Previously the h-bridge state would remain in OFF state until over-current or shutdown has been reached and never transition to ON/OFF. Additionally the usage warn limit was not implemented to set the StatusLED when ~75% utilization was detected.

commit e097dd3e1b64ede5fe7dfbb9b57077695d3eae97
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Apr 12 06:06:23 2020 -0700

    :pencil: TODO list update

commit 9283a6dec90ca680794763555a8f6a7aebc8ed92
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Apr 12 06:06:13 2020 -0700

    :tractor: Reducing global variables

    Moving trackInterface to be a locally declared variable in app_main.

commit 19adca60c1d5ebe38352542799fee456dd6b50d0
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Apr 9 06:49:11 2020 -0700

    :ambulance: Fix crash when reboot() is called

    When reboot() is called the primary Executor is shutdown and all background tasks terminated. Unfortunately some tasks use timers which were not being canceled prior to termination leading to asserts.

commit 36d1919384cdb6a032834c2fe37e9b21f4235ca9
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Apr 9 06:47:19 2020 -0700

    :ambulance: Fix enable pin usage

    The code was incorrectly using set() (HIGH) when it should use clr() (LOW).

commit a8fec40687010b4feef45e4b88262e83db1ea4ab
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Apr 9 05:59:28 2020 -0700

    :pencil: Fix typo in default

commit 2156f67e3d14734b6a43f683e2efbe8b65ba2931
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Apr 8 15:23:41 2020 -0700

    :pencil: TODO updates

commit 19f27206cf733d48f22a2c6e23dcf7531f0b34d9
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Apr 8 15:10:42 2020 -0700

    :ambulance: Fix Esp32Gpio::get() for output pins

commit e48ab86ee3a792f8b4ff4bc131ac8a67ce0db57c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Apr 8 09:23:33 2020 -0700

    :pencil: add check for s88 reset set to -1

commit 33437ad95b78c3ab4d62346215954e43c98a1df5
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Apr 8 08:04:02 2020 -0700

    :pencil: silence estop handler on startup

commit f4dd64d1a0fc9892178c35fedafce1e567d740ac
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Apr 8 07:43:20 2020 -0700

    :ambulance: Fixing DCC signal generation

    With the refactoring/split of RMTTrackDevice recently the ENCODE_PACKET() macro was causing the RMT to only transmit one packet. This caused the signal pin to remain in a LOW state indefinitely.

    Reintroduced the encode_next_packet() method with the ENCODE_PACKET() macro expanded in-place in the method with a TODO marker for marklin-motorola encoding to be added in the future.

    An unexpected bug was found with using uninitialized<type>, it appears that it does not correctly initialize all members of the underlying data type when emplace() is called. This was leading to packetQueue_ being null when the RMT TX complete ISR was fired.

commit bc78ab740f9b283805f3e26e84acc13ddb79c3f3
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Apr 8 05:53:03 2020 -0700

    :pencil: Set default for SoftAP name

commit 35a6b6968c39a9f6c225c63200f6ff6f89759c0c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 11:49:26 2020 -0700

    :pencil: bump cmake version

commit 8739155b3a34acfac347008ba9ff74e02399b040
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 11:22:51 2020 -0700

    :green_heart: export IDF_PATH...

commit ebfebe39dc34d6aae1b3ee788a73ad0162e7a5fb
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 11:20:14 2020 -0700

    :green_heart: remove debug code

commit af9c4d29c6a9e276832f5073f24348124ee8ddb3
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 11:17:27 2020 -0700

    :pencil: dump directory content and sorted env

commit 450c49929f8b15cbcc4b9946c798c9ff5ea22f0b
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 11:14:12 2020 -0700

    :pencil: dump env

commit df147d149bd49a456e26c6b2c6d431480ee21c2a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 11:04:34 2020 -0700

    :pencil: Split ninja/cmake

commit 957d2352cc2b3107881bf6f0972e0bf2f19874a7
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 11:03:03 2020 -0700

    :pencil: swap out dependency fecth for explicit cmake/ninja install

commit 9b4a05737d9bb180466d220aed2e56c6d18397ce
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 10:39:04 2020 -0700

    :green_heart: Fixing up actions

commit 7f63f7d724fa7f7c7c5c2f4d2745c8fa8971a940
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 10:29:28 2020 -0700

    :pencil: move toolchain / idf to workflow

commit db200d22e2f7aac1d6e2b241818713ebe0112f05
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 09:13:01 2020 -0700

    :pencil: Check for IDF pre-checked out by GH

commit 479c0d5e44d45e9194cb654bb6e010fb6c730f17
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 09:03:31 2020 -0700

    :pencil: fix path for idf repo checkout

commit 9a257a3869a653c5998a417287116134df2ab667
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 09:01:43 2020 -0700

    :tractor: Move to GH Actions checkout for IDF code.

commit adc5c46b2ece67f913f29ae1c8abc72331a4fe8e
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 08:46:32 2020 -0700

    :tractor: S88 updates to make reset pin optional

commit a91dac9f3a378793210bc6a4095d7022cad28c4a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 08:27:38 2020 -0700

    :pencil: rename GpioInput -> GpioInputNP

commit d62b4dd35589189c360c17cafcb0b4c3fce93691
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 07:23:46 2020 -0700

    :green_heart: Fixing broken reference to stack

commit 1a986eb43ee61ca2418ae98bac169772cc090044
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 06:52:33 2020 -0700

    :pencil: Expose RMT timing details in menuconfig

    By adjusting these values it is possible to debug the DCC signal with LEDs on the enable and signal pins. However, this will make the signal unusable for DCC decoders!

commit 618d1ce0a5c20a5ef969b9b3eda484e5ae318829
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 06:42:40 2020 -0700

    :pencil: pull in experimental fixes for json.hpp

    https://github.com/nlohmann/json/pull/2019
    https://github.com/nlohmann/json/pull/2025

commit eb5755bf934f35305b9433d8d22eb3b5a2525dd3
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 06:08:08 2020 -0700

    :pencil: Remove hardcoded track name

commit 3c3c0e444b23f4879637c1761e3f48a6a385c441
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Apr 6 06:06:56 2020 -0700

    :pencil: Remove duplicated log entries.

commit b1916101782f3f816d9e9e1a990642f561d9a947
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Apr 5 09:45:03 2020 -0700

    :ambulance: Fix bug with log statement being printed for legacy roster import

commit 7b4ab74c6e771d819629bf247d86dda7a3a397f8
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Apr 5 09:44:39 2020 -0700

    :tractor: Remove lccStack global variable.

commit 19678ee6d69d9928f494e7d934c9f5a0bec8717d
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Apr 5 07:38:10 2020 -0700

    :pencil: Fixing description on thermal input pin

commit 6088cadbbfd9ae0e61004043b94fc2af2e1d75c8
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Apr 5 07:37:18 2020 -0700

    :sparkles: Add ability to specify GPIO factory reset pin.

    When this pin reads LOW on startup it will force clear all persistent configuration. Default setting for this pin is not-configured (-1).

commit 7a5b253cda90a374ccd8d80adcb83551e76da4d8
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Apr 4 03:54:44 2020 -0700

    :ambulance: String based config entries can't be directly used for conditional checks.

commit 290ad60055079f6ad751a798da3e84bce5ef1447
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Apr 2 07:25:31 2020 -0700

    :pencil: Adding tracking note for wifi fallback option

commit 33b6eb348c503062f7e2c1df6521441f120176cc
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Apr 2 07:22:21 2020 -0700

    :pencil: Update TODO list for v1.5.0.

commit b62328685393e807a0306e6d474cbe5a6370352a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Apr 2 07:20:33 2020 -0700

    :tractor: Splitting up RMTTrackDevice.
    :pencil: Adding validation for config json.
    :pencil: remove CAN RX/TX pins from config.

    The existing RMTTrackDevice class was becoming too large and complicated to manage easily. The addition of RailCom was a big contributor to the complications.

    The new code now creates two instances of RMTTrackDevice (OPS and PROG) which will operate independently (RMT TX complete ISR is not independent though). RailCom functionality is shifting to RailcomDriver instead which will be for OPS only.

commit 516217204ac386e5da95fdf7c8ddb8f1a5e1bd0c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Mar 27 08:10:23 2020 -0700

    :pencil: Small fix for CONFIG_LCC_TCP_STACK usage

commit 66ea70ff8e33471f422bf41e18c2858c0272cae9
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Mar 26 17:00:05 2020 -0700

    :pencil: Add nodeid based check for valid trains.

commit 7292d50ceb61df548d5a103d145293adf5055718
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Mar 26 16:29:50 2020 -0700

    :pencil: Set all IDF log levels to ERROR

    The latest IDF v4 code seems to have brought in some INFO output by default in the WiFi library. So now it is silenced by default.

commit d276afe34857f71521c8743fe1df2be3c7d9c171
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Mar 26 16:28:55 2020 -0700

    :tractor: Combine status collector and status display

    With this change the LCC node count is now accurately reflected based on the nodes that are actually visible. Local nodes are counted as virtual train nodes hosted by the CS and the CS itself, everything else is considered a remote node.

commit c19327c9f1ced1bb680fd86f9bc9cfab73e7aa19
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Mar 25 08:22:00 2020 -0700

    :umbrella: Add pin validation to build system

    With this change pins 6-11 are rejected for all usages, 0-3,5,12 will also be rejected for most usages if "Allow usage of restricted GPIO pins" is not enabled.

commit d0c902fc4832a28f5100e8f8a4da200c95f64e9f
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Mar 23 07:01:49 2020 -0700

    :pencil: Remove obsolete defines

commit 154833d7eb04465b44c736858d1b08c75067c3c5
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Mar 23 06:37:12 2020 -0700

    :pencil: rearrange defaults for LCC_HUB_USE_SELECT

commit 65b0b21ddb1bee0fb83c4f0605fd30a637ffda49
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Mar 23 06:36:22 2020 -0700

    :pencil: Remove refernece to ARDUINO

commit 8dff7a81614dbc9399adfea303a8f2650a2c391f
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Mar 23 06:35:54 2020 -0700

    :tractor: Cleanup/document OSSelectWakeup for IDF v4/v3

commit f1e6a983c7c54ea4ff4522e313859c834443dfd7
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Mar 22 06:50:08 2020 -0700

    :pencil: Add mbedtls dependency

commit bd47b916cae79b7491b2a10b2eb1bb1fc062eb23
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Mar 22 06:39:30 2020 -0700

    :ambulance: hardcode softap ssid when in softap+station mode.

commit 5e10de664a392b9055fc9eea4c5b5249c77e07de
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Mar 22 06:39:02 2020 -0700

    :arrow_up: OpenMRN sync

commit a3be516820860179a4c7df1f137b80b032275994
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Mar 21 16:38:45 2020 -0700

    :tractor: Adjust code to support Tcp stack instead of Can stack (partial)
    :tractor: Moved WiFi config to Configuration component
    :racehorse: Allow enabling select() for LCC connections.

commit 2175a095a74d3b2aeb4713192d90707fff3e4f38
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Mar 21 16:30:46 2020 -0700

    :pencil: Sync with OpenMRN

commit ca4f0c2b7f0043ae27c31965414375cd32f56195
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Mar 21 06:38:53 2020 -0700

    :art: Fixing formatting

commit fdb6c1c920ce02427b05f137b03f5f086eb3a881
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Mar 21 06:38:30 2020 -0700

    :ambulance: Fixing web roster display

    With the shift to the LCC Train Search Protocol the loco roster was reworked and description and type were no longer persistent. Dropped these two fields and added "name" which is displayed on the throttles instead.

commit e768075ffa8ec9e9a14196ac514ebb161c07a90e
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Mar 20 07:57:08 2020 -0700

    :speaker: Add options for logging in GPIO

commit 9fce64522f95c5badf9d0e44beed496bfe2d54fc
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Mar 20 07:51:13 2020 -0700

    :speaker: Add configurability of RMT log levels (not fully used yet)

commit 00a3cc45307e4def57234d9d051dd03e0a473b14
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Mar 20 07:50:54 2020 -0700

    :pencil: Add note about log levels

commit a901e13d2c2abda57524a80da96d42393d09990f
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Mar 20 07:47:13 2020 -0700

    :pencil: Fix config naming for turnout manager

commit acc3c3027602f754ee1559b0d33435a89b9fa63f
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Mar 20 07:41:39 2020 -0700

    :pencil: Minor fixes related to log level adjustments

commit e8bd8e2a078ce07885b56eecc8ecab141ecd3785
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Mar 20 07:06:04 2020 -0700

    :speaker: Add ability to control turnout manager log verbosity

commit ad3a003a83c4d9ae1d0d50e46098833a9e64e37e
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Mar 20 07:00:13 2020 -0700

    :pencil: Sync from OpenMRN with bugfix.

    In the PR for OpenMRN for these files it was noted that the get_ssid_scan_result method was exposing the internal data structure without the mutex protections and it was suggested to switch back to return by value instead.

commit 73fb352f48b0c0a2a7cb555e1de80440f264ced4
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Mar 20 06:57:49 2020 -0700

    :ambulance: refresh turnout type in vclick event

    When the turnout creation dialog pops up it resets the values in the form but failed to refresh the type selector.

commit 871179d25e065693ad4b744cc94882cd2de6252a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Mar 19 07:07:59 2020 -0700

    :speaker: Allow adjustment of HTTP/DNS log verbosity.

commit e2ccf34dcd78eda7eaa3e34a6450054eff167da6
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Mar 19 07:06:27 2020 -0700

    :ambulance: Fix Turnouts.h include path.

commit 64bda10878cd7b24761170d9caf9130e7d6fad3c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Mar 17 12:01:09 2020 -0700

    :ambulance: Add defaults for Nextion RX/TX pins

    Without these defaults the VSCode Espressif IDF plugin throws an error while running menuconfig and is unable to update config even after correcting the issue. This is not a problem with the commandline "idf.py menuconfig" though.

commit c0fd0f81c65f3f1680f260fb4793700c7f2c6cbc
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Mar 17 10:29:39 2020 -0700

    :pencil: Minor fix to "G" in OLED "thin" font.

commit ae189623dfb1c578c78975ddcc3c947b48b53b74
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Mar 17 09:09:47 2020 -0700

    :pencil: reorganize include lines by alpha

commit 233faac5e654ee6b3b8fdd0573350f20e4f28ba4
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Mar 17 08:15:07 2020 -0700

    :ambulance: Fix S88 compilation issues.
    :tractor: Convert Outputs & Sensors to use gpio_num_t internally.

commit f0fa996b920af630ae798e41fff3675d12532d41
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Mar 17 07:21:22 2020 -0700

    :tractor: Split Advanced Configuration options up.
    :tractor: Move S88 config option to top level GPIO.

commit fb32cf66f10e3084182bbbf78c7f906a19d1cdc9
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Mar 17 06:30:37 2020 -0700

    :fire: Remove ESP32 Command Station top level config (unused)
    :books: Add documentation to various config options under LCC.
    :fire: Hide LocoNet config options (unsupported currently)

commit 95465414be627a2d70b127377d855d2a86188510
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Mar 16 06:58:57 2020 -0700

    :books: Adding GPIO help entries for menuconfig.

commit 424cfdadb1392041ab5234bd9dec237adb928e76
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Mar 16 06:12:08 2020 -0700

    :ambulance: Remove HC12 from CS Features (unused in web)
    :ambulance: Remove H-Bridge validation from config load since it is not persisted

commit 5611bd79291a5a4ffc2681eb65e2f5ca64337276
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Mar 16 06:06:29 2020 -0700

    :ambulance: Swap SDA/SCL defaults..

commit 8a097d6447bb6d11c4febd5a9f0961929d6c3e0f
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Mar 15 07:47:31 2020 -0700

    :arrow_up: Sync OpenMRNLite from latest OpenMRN

commit 665e9d8e009421c24404f7770a389e92c5f34076
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Mar 15 05:49:28 2020 -0700

    :pencil: Default DISPLAY_SDA to 22

commit 4245e7349b6d952868fbc675eb4138f288645bf1
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Mar 15 05:26:04 2020 -0700

    :tractor: Combine sensors and outputs into GPIO component

commit 424f6fb8941f93af0330edd9627a721e82b95c18
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Mar 14 18:48:34 2020 -0700

    :ambulance: Ensure S88Sensors.h is included if enabled

commit a33202455508bf3fc735d3c254f54b782847773e
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Mar 14 07:35:14 2020 -0700

    :pencil: Increase main task stack to 9kb

commit 7f1ff3b58b2eaa9005beba4b0df1c8e593c08534
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Mar 14 07:17:22 2020 -0700

    :pencil: Add alternative font for StatusDisplay

commit 07f760e6b8a0e9e64546fda08f71c2e72c3f04cd
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Mar 14 06:48:37 2020 -0700

    :ambulance: Narrow the scope of mdnsInitLock_ and set mdnsInitialized_ before publishing deferred services

commit 240226b9e19fdfb3e05563e5cc812c57e53d8faa
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Mar 14 06:46:03 2020 -0700

    :tractor: move to pre-allocated MonitoredHBridges

commit 07c58e482a79ff104befeed7660e74bf027b499a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Mar 7 11:11:22 2020 -0800

    :green_heart: Fix readme in binary tree

commit 80afc4d6db0b6ac4ab5d524c36b73a99d0f1537b
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Mar 7 05:52:14 2020 -0800

    :pencil: Remove extra zip

commit 17a1418ef4404a356daa7959d64a403d18799d64
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Mar 7 05:06:27 2020 -0800

    :pencil: missed build.sh

commit 7cf2a83bfeca89f48eccd7835126d18327c2f525
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Mar 7 05:06:12 2020 -0800

    :pencil: Package binaries from the actions run.

commit cf134c26d0f865275b464f913a21b801ab297361
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Mar 7 05:00:20 2020 -0800

    :tractor: Removing WiFiInterface code (unused).

commit ac0bf0d192ee3c6631592faa2fa0c58525edc233
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Mar 6 07:18:09 2020 -0800

    :tractor: Move JMRI interface to it's own component

commit 4c13b4727e43b5bfc06946da7b43d0ece05e24bd
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Mar 5 11:34:27 2020 -0800

    :pencil: silence some warnings

commit bfdd1563e589343a1f65fd7f862ba0fbd8f17244
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Mar 5 09:31:13 2020 -0800

    :tractor: Restructure of components directories to remove "src"

commit bb7fce40417603481badb0a75f586558137f9ff3
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Mar 5 09:26:04 2020 -0800

    :pencil: Add defaults for S88

commit 241a302d305a1d60eee08455d2e15590cff4ab8c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Feb 29 08:23:15 2020 -0800

    :tractor: Combine EStopHandler into DCCSignalGenerator

commit b21c4e50176c65027ec5d388accd86d39ed1c82e
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Feb 28 06:54:08 2020 -0800

    :shirt: Add comment to disable unused var warning

commit 4e56512918d90d93490a7aa6295e836d640246eb
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Feb 28 06:53:52 2020 -0800

    :shirt: Clarify operator precidence

commit 08845e5ed1b2c9c5ad4271b7dc05f1c5798ac240
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Feb 28 06:53:12 2020 -0800

    :shirt: reduce scope of err var

commit d8d06497dd1b16ea86c7f7362ca7d3580ea7144a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Feb 28 06:06:54 2020 -0800

    :tractor: Splitting up packages a bit

    With packages being broken up a bit more some will become optional based on configuration requirements once CMake side is sorted.

commit 4df5b85d5e4d6acac8b93ae624891567505d9f47
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Feb 27 13:34:06 2020 -0800

    :art: Adjustments to code formatting and reducing log level.

commit 296a913f634d507d71c60aa00fd7b2eeb75d397a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Feb 27 05:32:58 2020 -0800

    :pencil: remove extra CallbackExecutable

commit eb32d5d40a7e2c33f4f8f0ffad7f43914d699991
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Feb 27 05:32:02 2020 -0800

    :pencil: minor updates as part of sync to OpenMRN

commit f60c6152a32d951bf8011f99b4d5fc254e94fa13
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Feb 26 06:37:01 2020 -0800

    :tractor: Breaking up Kconfig to make it easier to find options

commit 76425cff6762a59c9037c9fa70b1deba7ea53377
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Feb 25 08:10:47 2020 -0800

    :greenshirt: Fixing issues with build related to sensors/outputs.

commit ce66b8e8a8fa54d16b4f17104dcf38f745889bc0
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Feb 25 06:28:57 2020 -0800

    :pencil: Reset dirty flag on load to prevent unnecessary call to persist

commit a6bd4170f343bbf5acd6155adafbf605b4fa7c53
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Feb 24 15:50:31 2020 -0800

    :tractor: Moving chunks of code to components

    More component creation coming soon as well as splitting some of these up further.

commit 51e6ce3c82f65374cccb5bfd3e896f32ffc6e4bc
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Feb 22 08:31:42 2020 -0800

    :mute: reduce console output from train db.

commit 59a88e0a2421d20ba5e0d6579e06d09e6dcf7928
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Feb 22 08:05:22 2020 -0800

    :tractor: Updates to improve support for TCS UWT-100

    LCC Train Search protocol defaults to zero indexed db entries so using the loco address would not work correctly. This update makes everything use zero indexing.

    Still to be done is ensure traindb entries that are automatic idle show up immediately on startup of the CS.

commit 0f72ee76e00135a7e6f1b5207059001f965ad835
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Feb 19 15:38:09 2020 -0800

    :pencil: Add esp_system.h includes to ensure IDF version flags are picked up

commit 9a068db6818e5c14313e820c6939f02b92673f7a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Feb 19 15:37:25 2020 -0800

    :ambulance: correctly register LCC event handlers (estop, power-on/off)

commit 4b7a16fed19c5c4bba5867d512ee72146e74b456
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Feb 18 07:18:49 2020 -0800

    :pencil: split defaults arg

commit a0580e61014ccd03c24397167fcebf3c60932f48
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Feb 18 07:15:43 2020 -0800

    :pencil: quote SDKCONFIG_DEFAULTS

commit 203f709ab906051ce13ffb06986bc9b8d7d9decc
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Feb 18 06:10:54 2020 -0800

    :ambulance: Fixes for the PCB builds (RailCom & Status LED)

commit 1f93353fa6f864427960dd61754cf05b7a9b0ef2
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Feb 18 05:26:41 2020 -0800

    :pencil: Minor fix to bash formatting

commit ab4d397f23086f668b1b1c1034db655cb01541ca
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Feb 18 05:23:35 2020 -0800

    :construction: Adding PCB build back to GH Actions

commit 4f81091a5238591757d4a999060c13528b64319c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Feb 18 05:14:17 2020 -0800

    :pencil: Minor fixes to Kconfig.projbuild and OLED init text

commit 8e575c48a2e38b54d257356b8f73ae23903d6537
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Feb 17 14:48:46 2020 -0800

    :pencil: Sync pcb defaults

commit dca9c67a508922d7fff5c2a13397c6ca182c5c5e
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Feb 17 14:48:31 2020 -0800

    :green_heart: Add missing CONFIG_NEXTION guards

commit 6377dde871b190f0a49a4a96ee97a2d7a54b3bd7
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Feb 17 13:36:42 2020 -0800

    :green_heart: Move Nextion declaractions inside CONFIG_NEXTION check

commit 71899b9c4caca62cea44b20caaed7f411dbb802b
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Feb 17 12:29:13 2020 -0800

    :pencil: TODO update

commit 5bd3f32fc3f75e7aab91356b7212961453040a60
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Feb 17 12:27:10 2020 -0800

    :pencil: Split HttpServer includes to new dir

commit a5d829bbf83fef424d53867651f8f4c78851ef33
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Feb 17 12:26:40 2020 -0800

    :tractor: Update NeoNextion lib to compile with IDF v4.

    It compiles but is not tested.

commit 14dedd963a67c6b28657462bafa29faae7b456b1
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Feb 17 08:04:18 2020 -0800

    :pencil: Correct column count for IP address

commit 8d1997d5a6d7e75fabe8e5e82b66239d2aba2481
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Feb 17 07:34:55 2020 -0800

    :pencil: Correct initial state of track power on status display

commit 6db0f231e1daa2be6230f56766d1ad7095cf334a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Feb 17 07:31:23 2020 -0800

    :pencil: Move screen dimensions into Kconfig, remove tcp_clients (not very useful)

commit 058683aa8fef2c4b2b6a495e8ed20093964eec94
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Feb 17 06:12:30 2020 -0800

    :ambulance: Fixing SH1106 detection

    The register zero bitmask was too wide for the bits being tested resulting in some SH1106 screens not being detected correctly.

commit 811f1c2b10e4bc9cee93a320bb73d33a9caa8ffd
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Feb 16 12:23:31 2020 -0800

    :pencil: Add back the output from the I2C scan

commit b3b2b6179eb44bcaadfd05683fa6096eadc445c5
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Feb 16 10:36:55 2020 -0800

    :tractor: LCD now works

commit 5f792b4e2a99fb213e3ce9490dd4d03eaf8c702c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Feb 13 12:38:21 2020 -0800

    :tractor: OLED displays now work but have issues

commit 239927312cdc947bf081f07c1c34db9b67948a58
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Feb 13 09:29:51 2020 -0800

    :pencil: Remove lokdb refs

commit 5effde1976d602bd1ba608f4f99e7f3815650bf1
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Feb 8 09:52:47 2020 -0800

    :pencil: Move remaining config to Kconfig.projbuild

commit 9396a21f7a7683364677c4ab537562816e050938
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Feb 8 06:28:44 2020 -0800

    :pencil: Getting rid of trainNodes global variable

    More work will be done on this in the near future to streamline the train nodes interactions.

commit d4843dcdd0476f63a408987212829592b9ace97b
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Feb 7 06:45:24 2020 -0800

    :pencil: Move remaining configuration validations to CMakeLists.txt

commit 26d4d0c0da0cea422cc90dac816e6e8646b373c9
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Feb 6 06:12:45 2020 -0800

    :pencil: Update to CMake build system.

    1) Fixed sdkconfig.defaults usage for partition selection.
    2) Moving validation to CMakeLists.txt from ConfigValidation.h (partial)

commit 12690975a2e65d9cebe685a2005e222973da8dd5
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Feb 3 13:12:04 2020 -0800

    :ambulance: null terminate CDI file per LCC spec.

commit 164e97bc224a1fe9c03d15fa164995d00bf8e03f
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Feb 3 07:18:29 2020 -0800

    :pencil: Add IDF version check

commit 70a5804cbe0b24a13c6a832fd350e78389bdc401
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Feb 2 07:43:34 2020 -0800

    :pencil: Add error checking and size info to GH build.

commit 7e2f28065a09bb0c7aa0e5df4b5a4f1312b3b23a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Feb 2 07:22:54 2020 -0800

    :pencil: Add Ninja log analyzer

commit 1d89fd8cee0c2027f1eebd9bc8a50e4d096dccee
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Feb 2 07:15:43 2020 -0800

    :pencil: Move toolchain directory to end of tar cmd

commit 44b4231c69cbb0bbb8ea3b3bda5afbd45eb7f838
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Feb 2 07:13:06 2020 -0800

    :pencil: Fix toolchain path for GH

commit cec52b13b0793b9cdccf41d1573b70aadcc59911
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Feb 2 07:10:16 2020 -0800

    :pencil: toolchain path checks

commit be5cf75ca38ece5e18f3a74af1f02fb58bb7add4
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Feb 2 07:07:18 2020 -0800

    :pencil: fix typos

commit d63faaaa963ac742bb17e247ace3a582ec6b618c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Feb 2 07:03:00 2020 -0800

    :pencil: Test idf build on GH

commit f824ac24b298967922ad656a6790b83e06c83254
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Feb 1 10:49:54 2020 -0800

    :pencil: try 2

commit 490458b004e9621b2a46d5ce648cefe915012003
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Feb 1 10:49:13 2020 -0800

    :pencil: idf docker build

commit 9c7d3b942aecc4d0aceeb578cf4eb3a606865be1
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Feb 1 10:26:30 2020 -0800

    :tractor: :construction: Restructure of code and move to ESP-IDF v4.

    All arduino-esp32 dependencies are being removed. As such some functionality is 100% broken currently (status display, nextion, loconet, etc) but basic functionality appears to be intact. LCC CAN is not wired up yet as the CAN driver needs to be ported still.

    Building from code will require:
    1) ESP-IDF (https://docs.espressif.com/projects/esp-idf/en/release-v4.0/get-started/index.html)
    2) GZIP (must be in path)
    3) Run IDF_PATH/tools/idf.py menuconfig to configure CS features/functionality. The include files will not be used now!

    Before flashing to the ESP32 it is recommended to run "idf.py erase_flash" to start with a fresh configuation as some options have changed.

    Flashing the code to the ESP32 should be done with: idf.py flash monitor
    This will start the serial monitor immediately after flashing. It is recommended to have the toolchain bin directory in the PATH when doing this so that stacktraces are automatically decoded.

commit 201951d0820fbcf910e4b4c39bb1aadc7823a646
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Dec 3 15:02:39 2019 -0800

    :pencil: Carry over task priority adjustments from OpenMRN

commit d16001b3a812127e4d9ba53f489546b027c2de87
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Dec 3 15:01:53 2019 -0800

    :ambulance: Correct the Nextion SSID value

    The Nextion setup page was showing the hardcoded SSID from config and not the actual SSID being used. Moved the code to reference configStore instead for the SSID.

commit b633ecacbff854546a4f0542689425128df7edab
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Nov 29 11:42:22 2019 -0800

    :pencil: Update LN interface to at least compile again.

    This is still untested but should at least provide basic functionality again.

commit 605874bd7e60cf15ac288f5ec45fc9c784d2df4f
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Nov 27 05:56:41 2019 -0800

    :ambulance: Fixing packet send size for WS text under 126 characters.

    This fixes the WS disconnect error with FireFox, surprisingly Chrome didn't care that the WS stream had two bytes of junk after each small text packet.

commit 6098c1f020bb5b5e54a628bcfdf6306ced103127
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Nov 20 08:18:40 2019 -0800

    :pencil: PCB pinmap updates, removing old PCB readme.

commit c4d8f96e572c2d863d8ced1b344d21ab8eb9003f
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Nov 4 08:16:40 2019 -0800

    :pencil: Remove pre-init of tcp stack since the option will not be used.

commit ae0f968d932d8cafeec0e48f860bcfc552918945
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Nov 4 08:14:02 2019 -0800

    :ambulance: Switch to add/remove methods rather than Singleton approach directly

commit b43673c3d82048b52833b64f0d12bfd5a938e16f
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Oct 24 07:09:07 2019 -0700

    :pencil: correct the passing of the packet to the track

commit eb22a8d7017dbc3bf1d0e15e3342e22dc9afb46a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Thu Oct 24 06:35:29 2019 -0700

    :ambulance: Add null checks to OPS prog DCC++ commands

commit fe157a81fdd057cfb0c0a7c5ceb5c8a65b080fda
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Oct 22 08:19:04 2019 -0700

    :pencil: Add diagnostic log entries for function and loco commands received via DCC++ protocol.

commit 46f712df48b4e67fb76521b2154b3376d8ed5edf
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Oct 21 12:31:28 2019 -0700

    :pencil: record JMRI IP address upon connection

commit 49ed5d1aa21bea20e656bce3bea3c98fd7d6bdc2
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Oct 21 12:27:14 2019 -0700

    :pencil: add helper for retrieving the loco instance

commit 69a29643b5a1e3bf19d9fbdfe0ee012b67ab470f
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Oct 21 12:22:08 2019 -0700

    :pencil: Offload JMRI to the httpd service

commit 2ef6adfb4ebcb860a2ea46b5000cc8cc77e6af24
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Oct 21 08:28:26 2019 -0700

    :pencil: Expose new /fs endpoint

    The new /fs endpoint is usable for retrieving text based files from the filesystem. Used as /fs?path=<path to file>. No validation is done currently.

commit 90437abea8a92174813f5f71d7193e4e2da0732c
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Oct 21 08:27:17 2019 -0700

    :pencil: Add mime type for text/xml

commit bbfa9cbee63c8df9ef9d51d79b81f0952e222bce
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Oct 21 08:27:05 2019 -0700

    :pencil: Move to adjustable "main" task priority

commit 7eb1edb661dc09c3e0d3be22c2184809c256d87f
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Oct 20 07:21:50 2019 -0700

    :ambulance: Fix mDNS publishing #26

    The mdns_init() call requires that a valid IP address for it to start up the UDP socket(s). If mdns_publish is called prior to the init the publish will be stored and called from after initilization.

commit 5ed78fa50254275b4657407abdd625c82cad2945
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sat Oct 19 08:14:40 2019 -0700

    :ambulance: Add support to reschedule an mDNS publish

    This is a partial fix for #26.

commit 379aa133297048079a4f1942c97d947adc5dbc34
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Oct 18 15:35:07 2019 -0700

    :pencil: Revert defer and async update.

commit 153170f903388db41677a594b3c39ca51dbfa19d
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Oct 18 11:00:21 2019 -0700

    :pencil: Adding S88 conversion to TODO list

commit 6586a61b04a84963fedb972f7783446901ec5a77
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Oct 18 10:35:26 2019 -0700

    :pencil: Fix compilation failures in S88 code.

    This still needs a major overhaul to fit into the StateFlow model but it does at least compile now.

commit f533968eed495d4c5e474bbb45c6fb902642c3fe
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Oct 18 05:49:46 2019 -0700

    :pencil: Add defer async to the js scripts
    :pencil: Switch to string constent notation to avoid escaping characters in the embedded captive portal html code.

commit c5f7954c78d356e90ecdb53185c91bbda85f40eb
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Oct 18 05:48:38 2019 -0700

    :pencil: Improve the LCC validation logic to ensure that Config_LCC.h has been included.

commit 7c6c52ce047bab1a2de6bc8d8935c98c83be5685
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Oct 16 06:45:19 2019 -0700

    :pencil: Drop commented entries from sdkconfig.h

commit 03ccc7ffdc69aafe3b62d05e5ab575edd8fb40bf
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Oct 16 06:45:01 2019 -0700

    :ambulance: Fix DCC++ protocol compatibility issues

    The "S", "Z" and "Zex" commands were not enabled due to incorrect #define macro usage.

commit 4600d2a4d998f30188c345323e0930836f2e53ee
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Oct 16 06:43:40 2019 -0700

    :tractor: Move JMRI connection to use the StateFlow pattern

    This isn't perfect and needs a bit more refinement but it does appear to work.

commit b00d6ccc6812650cf8b49b92448f8b0664a33595
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Oct 16 05:23:24 2019 -0700

    :pencil: Remove mbedTLS config that is not needed.

commit 50f33003b59ad43381da187e9ddea8036c547f40
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Wed Oct 16 05:21:19 2019 -0700

    :arrow_up: Bump NeoPixelBus version to pick up WS2811 timings

commit 7c31196406b94777ceee8b628b001dda945e9735
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Oct 15 11:40:29 2019 -0700

    :pencil: Move up to C++14

commit 84f4bc4412f39c791e09f1de9039131b352a1b5a
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Oct 15 11:40:13 2019 -0700

    :tractor: Drop NeoBufferMethods as they are unused, add defines for PI if needed

commit d5a8e604e61450d5c5f64520bc38cbe7f289e5b8
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Mon Oct 14 07:12:40 2019 -0700

    :ambulance: Fixing Python3 issues

    As raised in issue #24, PlatformIO updated the VSCode extension to default to Python3 which breaks the resource_embedder.py script. This required a bit of cleanup of the code to support the changes in Python3 vs Python2.

commit 756de1aa687d8cf841d959612fe384d5040f5999
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Sun Oct 13 07:41:21 2019 -0700

    :pencil: Silence Nextion debug printfs...

commit 65f589114f20b96870d4d510f92728a9c583d1b6
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Fri Oct 11 14:04:23 2019 -0700

    :pencil: Revert flush change

commit c40ab0e3e57c3002a0dc475be8e47471c4150f9d
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Oct 8 08:20:14 2019 -0700

    :pencil: Move Nextion to use StateFlow.

    This is the first of likely many steps to move to the StateFlow approach. Still TBD is page transition checks are reported as failing even though the screen did transition.

commit 5a6d106b079c36ecc6ff34809876c05553e74f52
Author: Mike Dunston <m_dunston@comcast.net>
Date:   Tue Oct 8 07:03:51 2019 -0700

    :pencil: Adjustments to esp32 select() wakeup code.

    1) Allocate the VFS FD for each OSSelectWakeup instance rather than s…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants