Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused typedefs #2224

Merged
merged 1 commit into from
Jun 28, 2020
Merged

Remove unused typedefs #2224

merged 1 commit into from
Jun 28, 2020

Conversation

nlohmann
Copy link
Owner

This PR removes unused typedefs introduced #2203. Fixes #2221.

@nlohmann nlohmann self-assigned this Jun 27, 2020
@t-b
Copy link
Contributor

t-b commented Jun 27, 2020

@nlohmann Thanks for cleanup after me. ecbb275 (json_pointer::array_index: Use unsigned values for the array index when parsing, 2020-06-20) did not remove those typedefs. It would be nice to have clang-tidy run as part of CI to catch those.

@nlohmann
Copy link
Owner Author

@t-b No worries! I am running the latest GCC and Clang to check whether the code emits any warnings. As the compiler flags are not too portable even between GCC versions, I am still hesitant to add this to the CI. I see what I can do.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fa9f404 on issue2221 into 5ba0f65 on develop.

@t-b
Copy link
Contributor

t-b commented Jun 27, 2020

@nlohmann FYI: At https://github.com/tango-controls/cppTango/blob/tango-9-lts/.travis/gcc-latest/Dockerfile we are using a docker image of the latest (but fixed) GCC version and compile using that. The same approach could be used here. We are also using latest LLVM in docker.

@nlohmann nlohmann merged commit 1b4ea8f into develop Jun 28, 2020
@nlohmann nlohmann deleted the issue2221 branch June 28, 2020 13:08
@nlohmann nlohmann added this to the Release 3.8.1 milestone Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clang 9.0 report warning: unused type alias 'size_type' [-Wunused-local-typedef]
3 participants