Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the bug #2255

Closed
wants to merge 3 commits into from
Closed

fix the bug #2255

wants to merge 3 commits into from

Conversation

dota17
Copy link
Contributor

@dota17 dota17 commented Jul 9, 2020

This is a new PR for #2181.
From CI logs, the test SECTION("PR #2181 - regression bug with lvalue") has no error for this new PR.
I just added back the original method and then there would be two methods:

ValueType value(const typename object_t::key_type& key, const ValueType& default_value) const //  added back
...
ValueType value(const typename object_t::key_type& key, ValueType && default_value) const

But to be cautious, maybe some more testcases should be added.

@dota17 dota17 requested a review from nlohmann as a code owner July 9, 2020 13:21
gregmarr
gregmarr reviewed Jul 9, 2020
View reviewed changes
include/nlohmann/json.hpp Outdated Show resolved Hide resolved
gregmarr
gregmarr reviewed Jul 9, 2020
View reviewed changes
include/nlohmann/json.hpp Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 9, 2020 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 30dd9bd on dota17:fix_2181 into 4c7bd01 on nlohmann:develop.

nlohmann
nlohmann requested changes Jul 10, 2020
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a test to cover the added function for JSON pointers.

@3215656174

This comment has been minimized.

Sign in to view
@3215656174

This comment has been minimized.

Sign in to view
@nlohmann

This comment has been minimized.

Sign in to view
@3215656174

This comment has been minimized.

Sign in to view
@dota17 dota17 closed this Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmarr gregmarr gregmarr left review comments

@nlohmann nlohmann nlohmann requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dota17 @coveralls @3215656174 @nlohmann @gregmarr