Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in CBOR tag handling #2308

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Fix bug in CBOR tag handling #2308

merged 1 commit into from
Jul 25, 2020

Conversation

nlohmann
Copy link
Owner

This PR fixes a bug introduced in #2273. The skip_tags parameter was not passed to all functions. This resulted in a parse error even if json::cbor_tag_handler_t::ignore was passed.

@nlohmann nlohmann added this to the Release 3.8.1 milestone Jul 24, 2020
@nlohmann nlohmann self-assigned this Jul 24, 2020
@nlohmann nlohmann mentioned this pull request Jul 24, 2020
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 480ad52 on cbor_tags into 43e07bb on develop.

@nlohmann nlohmann merged commit 40b78d3 into develop Jul 25, 2020
@nlohmann nlohmann deleted the cbor_tags branch July 25, 2020 19:47
@nlohmann
Copy link
Owner Author

(Release item is in #2273)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
aspect: binary formats BSON, CBOR, MessagePack, UBJSON release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlohmann @coveralls