Allow to use get with explicit constructor #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unit-regression2.cpp:202:34: error: all parameters should be named in a function [hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
explicit Foo(const FooAlloc& = FooAlloc()) : value(false) {}
^
/*unused*/
unit-regression2.cpp:204:10: error: use default member initializer for 'value' [modernize-use-default-member-init,-warnings-as-errors]
bool value;
^
{false}
Initialization of "value" is redundant.
unit-regression2.cpp:207:7: error: 'FooBar::foo' should be initialized in the member initialization list [-Werror=effc++]
207 | class FooBar
| ^~~~~~
error: 'FooBar::foo' should be initialized in the member initialization list [-Werror=effc++]
nlohmann
added
the
review needed
nlohmann
removed
the
review needed
…3077 � Conflicts: � test/src/unit-regression2.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts commit 1101f0e which is the root cause for issue #3077.