Add build step for NVCC and fix a warning #3227
Conversation
nlohmann
changed the title
| @@ -664,6 +664,19 @@ class serializer | |||
| } | |||
| } | |||
|
|
|||
| // templates to avoid warnings about useless casts | |||
| template <typename NumberType, enable_if_t<std::is_signed<NumberType>::value, int> = 0> | |||
| bool is_negative_number(NumberType x) | |||
There was a problem hiding this comment.
template <typename NumberType>
enable_if_t<std::is_signed<NumberType>::value, bool> is_negative_number(NumberType x)
There was a problem hiding this comment.
Try this. You use legal but verbose and very indirect way for enable_if_t utilize.
There was a problem hiding this comment.
That is a normal way to do it for functions that are already templates. https://en.cppreference.com/w/cpp/types/enable_if
There was a problem hiding this comment.
"legal but verbose", Ok
And how about this?
json/include/nlohmann/detail/conversions/from_json.hpp
Lines 421 to 423 in 700b95f
There was a problem hiding this comment.
I'm not sure why @theodelrieu used the longer form here compared to the rest of the file, perhaps there was a technical reason. If not, it would make sense to use the value form as in the rest of the file. c5e63fd
This PR adds a CI step for NVCC and fixes a warning reported in #2676.