Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation error with NVCC #3234

Merged
merged 2 commits into from
Jan 2, 2022
Merged

Fix compilation error with NVCC #3234

merged 2 commits into from
Jan 2, 2022

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Dec 30, 2021 •
edited
Loading

This PR adds the code example from #3013 to be executed in the CI and fixes the error by using a different type alias.

Fixes #3013.

@nlohmann nlohmann marked this pull request as draft December 30, 2021 14:00
@nlohmann nlohmann added the state: help needed the issue needs help to proceed label Dec 30, 2021
@nlohmann

This comment has been minimized.

Sign in to view
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1ee61bf on issue3013_compile_error_with_nvcc into 1aca6cb on develop.

@nlohmann nlohmann changed the title Add regression test for #3013 Fix compilation error with NVCC Dec 31, 2021
@nlohmann nlohmann marked this pull request as ready for review December 31, 2021 13:58
@nlohmann nlohmann added review needed It would be great if someone could review the proposed changes. and removed state: help needed the issue needs help to proceed labels Dec 31, 2021
@nlohmann nlohmann self-assigned this Dec 31, 2021
@nlohmann nlohmann added this to the Release 3.10.5 milestone Dec 31, 2021
@nlohmann nlohmann mentioned this pull request Dec 31, 2021
Closed
@nlohmann nlohmann merged commit b69713c into develop Jan 2, 2022
@nlohmann nlohmann deleted the issue3013_compile_error_with_nvcc branch January 2, 2022 08:03
@ax3l
Copy link
Contributor

ax3l commented Jan 4, 2022

Thanks for the fix 🎉

Just as x-ref: now also reported as Nvidia bug ID 3487723 (developer.nvidia.com).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix review needed It would be great if someone could review the proposed changes.
Projects
None yet
Milestone
Release 3.10.5
Development

Successfully merging this pull request may close these issues.

ordered_json::reset() compile error with nvcc
3 participants
@nlohmann @coveralls @ax3l