Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/windows.yml: Add support for Visual Studio 2022 #3295

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

t-b
Copy link
Contributor

@t-b t-b commented Jan 25, 2022

This is available in github actions since some time now 1.

This is available in github actions since some time now [1].

[1]: actions/runner-images#3949
@t-b t-b marked this pull request as ready for review January 25, 2022 14:21
@t-b t-b requested a review from nlohmann as a code owner January 25, 2022 14:21
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also edit the "Supported Compilers" section in the README (https://github.com/nlohmann/json/blob/develop/README.md?plain=1#L1036)?

@t-b
Copy link
Contributor Author

t-b commented Jan 25, 2022

Done.

@t-b t-b requested a review from nlohmann January 25, 2022 19:31
@nlohmann
Copy link
Owner

Done.

Thanks, can you also add a line to the table?

The version and the build engine version (aka MSBuild version) were
taken from [1].

[1]: https://github.com/actions/virtual-environments/blob/win22/20220116.1/images/win/Windows2022-Readme.md
@t-b
Copy link
Contributor Author

t-b commented Jan 25, 2022

Jeep.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.10.6 milestone Jan 26, 2022
@nlohmann nlohmann self-assigned this Jan 26, 2022
@nlohmann nlohmann merged commit 4d4c273 into nlohmann:develop Jan 26, 2022
@nlohmann
Copy link
Owner

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants