Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: windows-2016 has been deprecated; remove jobs #3416

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

As previously mentioned windows-2016 is now deprecated. Remove msvc2017* jobs from the workflow.
GH offers no replacement for jobs requiring "Visual Studio 15 2017".

@nlohmann nlohmann removed their request for review April 4, 2022 05:14
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also update the README section and remove the lines for MSVC 2017?

@coveralls
Copy link

coveralls commented Apr 4, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 9d11f0a on falbrechtskirchinger:drop-windows-2016 into 6121dbb on nlohmann:develop.

@falbrechtskirchinger
Copy link
Contributor Author

Done.

The compiler list in README needs a thorough update at some point. GCC 11 (experimental) doesn't seem right, for example.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Apr 4, 2022
@nlohmann nlohmann added this to the Release 3.10.6 milestone Apr 4, 2022
@nlohmann nlohmann merged commit 33b75e5 into nlohmann:develop Apr 4, 2022
@nlohmann
Copy link
Owner

nlohmann commented Apr 4, 2022

Thanks!

@falbrechtskirchinger falbrechtskirchinger deleted the drop-windows-2016 branch April 4, 2022 11:19
@nlohmann
Copy link
Owner

nlohmann commented Apr 6, 2022

Done.

The compiler list in README needs a thorough update at some point. GCC 11 (experimental) doesn't seem right, for example.

Fixed in #3420.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants