Prevent ndarray size vector from recursive use, fix nlohmann/json#3503 #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll check. |
|
No problems found so far. |
nlohmann
requested changes
May 22, 2022
nlohmann
added
aspect: binary formats
|
Thanks a lot! I will merge this once AppVeyor is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the broken ND array objects in #3503 were results of embedding arrays inside an ND-array size. In #3500, I added a flag to prevent recursive embedding but missed the
get_ubjson_size_typefunction. now this is added. The test data throw errors as expected.let me know if the fuzzer test still find something else after this patch.