Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new CI image #3528

Merged
merged 6 commits into from
Jun 12, 2022
Merged

Use new CI image #3528

merged 6 commits into from
Jun 12, 2022

Conversation

nlohmann
Copy link
Owner

  • use CI image 2.4.0
  • add new flags for GCC 13

@coveralls
Copy link

coveralls commented Jun 10, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 079e97b on new_ci into 48a102c on develop.

@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Jun 10, 2022
@nlohmann
Copy link
Owner Author

@falbrechtskirchinger PTAL - 32 bit support is now also enabled.

@nlohmann nlohmann mentioned this pull request Jun 10, 2022
2 tasks
README.md Show resolved Hide resolved
@nlohmann nlohmann self-assigned this Jun 12, 2022
@nlohmann nlohmann added release item: 🔨 further change and removed review needed It would be great if someone could review the proposed changes. labels Jun 12, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone Jun 12, 2022
@nlohmann nlohmann merged commit af34396 into develop Jun 12, 2022
@nlohmann nlohmann deleted the new_ci branch June 12, 2022 12:31
@falbrechtskirchinger
Copy link
Contributor

Welp. I hoped you'd merge one of my 32bit PRs into this one first before I'd do a final review.

The addition of readability-simplify-boolean-expr triggers a bunch of errors on my system with a recent Clang 15 build. Specifically in HEDLEY_(UN)LIKELY.

@nlohmann
Copy link
Owner Author

Oh, sorry. But readability-simplify-boolean-expr is excluded. In this PR.

@falbrechtskirchinger
Copy link
Contributor

Oh, sorry. But readability-simplify-boolean-expr is excluded. In this PR.

Oh, good. I just quickly glanced at it and misinterpreted the plus sign from the diff. I'll see if there's anything else.

@nlohmann
Copy link
Owner Author

I wished Clang-Tidy was more flexible and one could define a list of sources that you care about and treat warnings outside these files as out of scope. If I had a stupid Boolean tautology checked in "my" code, I would act on it. But not if it's the consequence of piling up calls from different libraries...

@falbrechtskirchinger
Copy link
Contributor

I wished Clang-Tidy was more flexible and one could define a list of sources that you care about and treat warnings outside these files as out of scope. If I had a stupid Boolean tautology checked in "my" code, I would act on it. But not if it's the consequence of piling up calls from different libraries...

Agreed.

Everything else looks mostly good. The bool() cast could probably have been removed entirely. std::conditional doesn't do that, I'm sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants