Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable overriding test properties and set Unicode test timeouts #3580

Merged
merged 2 commits into from
Jul 17, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

  • Add TEST_PROPERTIES to json_test_set_test_options() to enable overriding test properties similarly to overriding build settings (COMPILE_DEFINITIONS, etc.).
  • Set timeouts for Unicode tests 2 to 5 by matching the output (100000 of 1641521 UTF-8 strings checked).

This should prevent timeouts in CI (as witnessed in recent weeks) and fix #3579.

@coveralls
Copy link

coveralls commented Jul 14, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 90b5674 on falbrechtskirchinger:test-timeout into d4daaa8 on nlohmann:develop.

Allow overriding test properties via json_test_set_test_options().
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jul 17, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone Jul 17, 2022
@nlohmann nlohmann merged commit 71bdaf5 into nlohmann:develop Jul 17, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the test-timeout branch July 17, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unicode4 test consistently fails on RISC-V hardware
3 participants