Add regression tests for #3204 and #3333 #3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falbrechtskirchinger
force-pushed
the
regression-tests
branch
from
e84fd26
to
1fab815
Compare
falbrechtskirchinger
force-pushed
the
regression-tests
branch
from
1fab815
to
062702a
Compare
falbrechtskirchinger
force-pushed
the
regression-tests
branch
2 times, most recently
from
20f2742
to
c3fa28c
Compare
|
Codacy complains about non-explicit constructors. Can this be fixed easily? |
|
You need to add exceptions for all 4. |
|
Hm. It's definitely required for 3333. 3204 should still break (in 3.10.5) with |
falbrechtskirchinger
force-pushed
the
regression-tests
branch
from
c3fa28c
to
0117c9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both #3204 and #3333 were fixed by #3604. Add regression tests.
Closes #3204.
Closes #3333.