Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amalgamate the forward declaration header #3679

Merged
merged 3 commits into from Aug 7, 2022
Merged

Amalgamate the forward declaration header #3679

merged 3 commits into from Aug 7, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

As discussed, we need to amalgamate json_fwd.hpp to make it usable as a standalone file (again).

@coveralls
Copy link

coveralls commented Aug 5, 2022 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 3e8e8eb on falbrechtskirchinger:amalgamate-fwd into b0422f8 on nlohmann:develop.

nlohmann
nlohmann requested changes Aug 5, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also adjust:

  • .github/CONTRIBUTING.md
  • .github/PULL_REQUEST_TEMPLATE.md

@falbrechtskirchinger falbrechtskirchinger mentioned this pull request Aug 6, 2022
Merged
@falbrechtskirchinger
Copy link
Contributor Author

I've updated integration/index.md as well.

falbrechtskirchinger
falbrechtskirchinger commented Aug 7, 2022
View reviewed changes
Copy link
Contributor Author

@falbrechtskirchinger falbrechtskirchinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@falbrechtskirchinger falbrechtskirchinger mentioned this pull request Aug 7, 2022
Merged
nlohmann
nlohmann approved these changes Aug 7, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.2 milestone Aug 7, 2022
@nlohmann nlohmann linked an issue Aug 7, 2022 that may be closed by this pull request
json_fwd.hpp no longer standalone #3656
Closed
2 tasks
@nlohmann nlohmann merged commit 231f310 into nlohmann:develop Aug 7, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the amalgamate-fwd branch August 7, 2022 16:22
@hahnjo hahnjo mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

@shaischaudhry shaischaudhry shaischaudhry approved these changes

Assignees
No one assigned
Labels
CMake documentation L
Projects
None yet
Milestone
Release 3.11.2
Development

Successfully merging this pull request may close these issues.

json_fwd.hpp no longer standalone
4 participants
@falbrechtskirchinger @coveralls @nlohmann @shaischaudhry