Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix natvis XML #3863

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Fix natvis XML #3863

merged 2 commits into from
Dec 9, 2022

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Dec 4, 2022

Closes #3858

@nlohmann nlohmann self-assigned this Dec 4, 2022
@nlohmann nlohmann mentioned this pull request Dec 4, 2022
Closed
2 tasks
@github-actions github-actions bot added the S label Dec 4, 2022
@coveralls
Copy link

coveralls commented Dec 4, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling b965780 on fix_natvis_xml into 24ba54e on develop.

@github-actions github-actions bot added CI M and removed S labels Dec 4, 2022
@Adanteh
Copy link

Adanteh commented Dec 9, 2022

I can say this XML works good for me :)

@nlohmann nlohmann added this to the Release 3.11.3 milestone Dec 9, 2022
@nlohmann nlohmann merged commit 349e4b3 into develop Dec 9, 2022
@nlohmann nlohmann deleted the fix_natvis_xml branch December 9, 2022 15:34
nlohmann added a commit that referenced this pull request Dec 11, 2022
@nlohmann
Fix natvis XML (#3863)
37a30d4 
* 🐛 fix natvis XML

* 🐛 fix natvis XML
nlohmann added a commit that referenced this pull request Dec 11, 2022
@nlohmann
Fix natvis XML (#3863)
6289c5c 
* 🐛 fix natvis XML

* 🐛 fix natvis XML
@nlohmann nlohmann mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
CI M
Projects
None yet
Milestone
Release 3.11.3
Development

Successfully merging this pull request may close these issues.

Generated natvis is invalid XML
3 participants
@nlohmann @coveralls @Adanteh