Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Meson. #576

Merged
merged 3 commits into from
May 10, 2017
Merged

Adding support for Meson. #576

merged 3 commits into from
May 10, 2017

Conversation

Type1J
Copy link
Contributor

@Type1J Type1J commented May 8, 2017

Although the use of this library is very convenient by just copying over the header to another project, this makes it easy for those who want to checkout a particular commit or the HEAD at the build time of their project when they use the Meson Build System.

It adds only 1 file (meson.build), and some usage info in the README.md file.

Meson is a C++ build system, like CMake, but simpler. It aims to cut down on the time spent working on build files, and the time spent compiling.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.722% when pulling 31fe2f5 on Type1J:develop into 962da00 on nlohmann:develop.

@Type1J
Copy link
Contributor Author

Type1J commented May 8, 2017

I'm not sure what happened with CI. I didn't change the .hpp files, just the README.md file, and I added meson.build, which shouldn't impact the build that's currently in place.

@nlohmann
Copy link
Owner

nlohmann commented May 8, 2017

No worries - Travis is sometimes a bit buggy. I restarted the failed job. It should be fine.

@Type1J
Copy link
Contributor Author

Type1J commented May 8, 2017

I think Travis is having a bad day.

README.md Outdated
@@ -66,6 +66,30 @@ to the files you want to use JSON objects. That's it. Do not forget to set the n

:beer: If you are using OS X and [Homebrew](http://brew.sh), just type `brew tap nlohmann/json` and `brew install nlohmann_json` and you're set. If you want the bleeding edge rather than the latest release, use `brew install nlohmann_json --HEAD`.

If you are using the Meson Build System, then add a file called `nlohmann_json.wrap` to a file to your `subprojects` directory with the following 4 lines:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this text is too long. It reads more than an advertisement for Meson than as a brief description how to use the library if you are using Meson. Compare this to the description of Homebrew above. As I never used Meson before, it's hard to judge what the "minimal" description should be though.

@Type1J
Copy link
Contributor Author

Type1J commented May 9, 2017

The commits that I made per your review only touched the README.md file, but Travis CI is still not working correctly, it seems.

@nlohmann
Copy link
Owner

nlohmann commented May 9, 2017

As I said, Travis is sometimes a bit buggy.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.722% when pulling 87744fd on Type1J:develop into 962da00 on nlohmann:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.722% when pulling 87744fd on Type1J:develop into 962da00 on nlohmann:develop.

@nlohmann nlohmann merged commit 15ef9b8 into nlohmann:develop May 10, 2017
@nlohmann
Copy link
Owner

Thanks!

@nlohmann nlohmann mentioned this pull request Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants