Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move lambda expression outside of assert to prevent "unevaluated" error #706

Closed
wants to merge 1 commit into from
Closed

Move lambda expression outside of assert to prevent "unevaluated" error #706

wants to merge 1 commit into from

Conversation

chuckatkins
Copy link
Contributor

Fixes #705

nlohmann
nlohmann approved these changes Aug 22, 2017
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Aug 22, 2017
@nlohmann nlohmann added this to the Release 3.0.0 milestone Aug 22, 2017
@chuckatkins chuckatkins mentioned this pull request Aug 22, 2017
Closed
@chuckatkins
Copy link
Contributor Author

Please see discussion in #705 for more details as to why this happens. TLDR: This is caused by a glibc bug that has been already fixed upstream, and this is really just a workaround for the issue so you may want to change your mind on whether or not to take this.

@nlohmann nlohmann closed this Aug 22, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7da0450 on chuckatkins:fix-gcc7-uneval-lambda into cd53790 on nlohmann:develop.

@tramseyer
Copy link

Consider adding static_cast<void>(lf_is_contiguous); to avoid "set but not used" warning when in release mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
None yet
Projects
None yet
Milestone
Release 3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chuckatkins @coveralls @tramseyer @nlohmann