New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main_feature为all时，处理了2次word_embedding，没有处理char_embedding？ #5

Open

liuyaox opened this issue Jul 20, 2019 · 0 comments

liuyaox commented Jul 20, 2019

daguan-classify-2018/src/model/attention1.py

Line 41 in e2539e5

    
           word_embedding = Embedding(self.max_w_features, self.word_embed_size, weights=[self.word_embedding], trainable=False, name='word_embedding')

代码很好，学到很多~

有个疑问：这里应该是char_embedding吧？因为上面line21-24表示当main_feature为all时处理的是word_embedding，此时应该补充处理一下char_embedding吧？

同样的疑问也在textcnn_model.py中出现了，line37-40， line53-55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment