Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: add support for unpickling array.array values #9

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

sbinet
Copy link
Collaborator

@sbinet sbinet commented Nov 17, 2023

Fixes #2.

@sbinet
Copy link
Collaborator Author

sbinet commented Nov 17, 2023

PTAL @marco-nicola.

For some reason, trying to unpickle the data generated for the L and Q array.array type codes, fails with:

--- FAIL: TestP4Carray (0.00s)
    --- FAIL: TestP4Carray/L (0.00s)
        pickle_test.go:789: unknown opcode: 0x27 '''
        pickle_test.go:751: got=<nil>, want=[0 1 2 3]
    --- FAIL: TestP4Carray/Q (0.00s)
        pickle_test.go:789: unknown opcode: 0x27 '''
        pickle_test.go:751: got=<nil>, want=[0 1 2 3]

also, I couldn't test all the UTF cases (UTF-{16,32} x {LittleE, BigE}).
so, coverage for the u typecode isn't too great.

Fixes nlpodyssey#2.

Signed-off-by: Sebastien Binet <binet@cern.ch>
@sbinet sbinet mentioned this pull request Nov 20, 2023
@matteo-grella matteo-grella merged commit 7bc7213 into nlpodyssey:master Nov 20, 2023
1 check failed
@sbinet sbinet deleted the issue-2 branch November 20, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for array type
2 participants